Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-24] [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends #43671

Closed
MitchExpensify opened this issue Jun 13, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@MitchExpensify MitchExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sakluger
Copy link
Contributor

Sounds like this will be handled internally - I asked @MitchExpensify to confirm.

@sakluger sakluger added the Internal Requires API changes or must be handled by Expensify staff label Jun 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
@trjExpensify
Copy link
Contributor

Hm, this is a frontend issue isn't it?

@fabioh8010
Copy link
Contributor

@trjExpensify Yes, it's frontend issue

@trjExpensify trjExpensify removed the Internal Requires API changes or must be handled by Expensify staff label Jun 18, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jun 18, 2024
@sakluger
Copy link
Contributor

Ah sorry, @fabioh8010 and @pac-guerreiro are both from Callstack and will be working on all Free Trial related projects.

@fabioh8010 and @pac-guerreiro, will both of you be working on this GH issue or just one of you? And will there be one or multiple PRs?

Thanks!

@fabioh8010
Copy link
Contributor

fabioh8010 commented Jun 19, 2024

@sakluger Just one of us (not decided who is going to pick at the moment), and will probably be one PR.

@trjExpensify trjExpensify changed the title [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends [Free trial] [Hold #43672] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends Jun 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 21, 2024
@trjExpensify
Copy link
Contributor

Put this on hold for #43672 where we'll first tackle the logic for when a free trial starts, before here and when a free trial ends.

@sakluger
Copy link
Contributor

Thanks for clarifying, @fabioh8010. Let me know once you are ready for one of you to take it so that I can reassign the issue if needed.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 21, 2024
@sakluger
Copy link
Contributor

I'm going to move this to weekly while we wait for the hold issue to be completed.

@melvin-bot melvin-bot bot removed the Overdue label Jun 24, 2024
@sakluger sakluger added Weekly KSv2 and removed Daily KSv2 labels Jun 24, 2024
@pac-guerreiro
Copy link
Contributor

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@rojiphil
Copy link
Contributor

@trjExpensify @sakluger And I can pick this up for review as C+

@trjExpensify
Copy link
Contributor

Awesome!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jul 3, 2024
Copy link

melvin-bot bot commented Jul 9, 2024

Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@iwiznia iwiznia assigned chiragsalian and unassigned iwiznia Jul 9, 2024
@trjExpensify trjExpensify changed the title [Free trial] [Hold #43672] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends Jul 16, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 17, 2024
@melvin-bot melvin-bot bot changed the title [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends [HOLD for payment 2024-07-24] [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 17, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
  • [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@rojiphil] Determine if we should create a regression test for this bug.
  • [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Jul 18, 2024
@sakluger
Copy link
Contributor

Summarizing payment on this issue:

Contributor: @pac-guerreiro - no payment required (Contractor)
Contributor+: @rojiphil $250, sent offer via Upwork: https://www.upwork.com/nx/wm/offer/103240375

@rojiphil
Copy link
Contributor

sent offer via Upwork: https://www.upwork.com/nx/wm/offer/103240375

@sakluger Accepted the offer. Thanks.

@sakluger
Copy link
Contributor

Great, thanks! Payment is complete.

@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
No open projects
Archived in project
Development

No branches or pull requests

9 participants