-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-07-24] [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends #43671
Comments
Triggered auto assignment to @sakluger ( |
Sounds like this will be handled internally - I asked @MitchExpensify to confirm. |
Hm, this is a frontend issue isn't it? |
@trjExpensify Yes, it's frontend issue |
Ah sorry, @fabioh8010 and @pac-guerreiro are both from Callstack and will be working on all Free Trial related projects. @fabioh8010 and @pac-guerreiro, will both of you be working on this GH issue or just one of you? And will there be one or multiple PRs? Thanks! |
@sakluger Just one of us (not decided who is going to pick at the moment), and will probably be one PR. |
Put this on hold for #43672 where we'll first tackle the logic for when a free trial starts, before here and when a free trial ends. |
Thanks for clarifying, @fabioh8010. Let me know once you are ready for one of you to take it so that I can reassign the issue if needed. |
I'm going to move this to weekly while we wait for the hold issue to be completed. |
Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task! |
@trjExpensify @sakluger And I can pick this up for review as C+ |
Awesome! |
Triggered auto assignment to @iwiznia, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-07-24. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Summarizing payment on this issue: Contributor: @pac-guerreiro - no payment required (Contractor) |
@sakluger Accepted the offer. Thanks. |
Great, thanks! Payment is complete. |
This covers this section of the design doc:
cc @fabioh8010 @pac-guerreiro as you'll be picking this up
Issue Owner
Current Issue Owner: @saklugerThe text was updated successfully, but these errors were encountered: