[$250] Workspace - "It's not here" error when opening the subscriptions page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.81-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #42990

Action Performed:

1. Log in with a new Gmail account
2. Navigate to https://staging.new.expensify.com/settings/subscription

Expected Result:

I should be navigated to the subscriptions page

Actual Result:

"It's not here" error when opening the subscriptions page without a workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6508538_1718050861255.Gmail.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a859839633fc1d1d
• Upwork Job ID: 1802764274500701214
• Last Price Increase: 2024-06-17

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - "It's not here" error when opening the subscriptions page

What is the root cause of that problem?

When there is no workspace, we display NotFoundPage.

App/src/pages/settings/Subscription/SubscriptionSettingsPage.tsx

Lines 26 to 34 in fb276f4

	const subscriptionPlan = useSubscriptionPlan();
	useEffect(() => {
	Subscription.openSubscriptionPage();
	}, []);
	if (!subscriptionPlan) {
	return <NotFoundPage />;
	}

What changes do you think we should make in order to solve the problem?

Instead of NotFoundPage we can show the same empty workspace section we use on workspace list page. We can extract the section and use it in both pages.

    if (!subscriptionPlan) {
        return (
            <ScreenWrapper testID={SubscriptionSettingsPage.displayName}>
                <HeaderWithBackButton
                    title={translate('workspace.common.subscription')}
                    onBackButtonPress={() => Navigation.goBack()}
                    shouldShowBackButton={shouldUseNarrowLayout}
                    icon={Illustrations.CreditCardsNew}
                />
                <ScrollView contentContainerStyle={styles.pt3}>
                    <View style={[styles.flex1, isLessThanMediumScreen ? styles.workspaceSectionMobile : styles.workspaceSection]}>
                        <FeatureList
                            menuItems={workspaceFeatures}
                            title={translate('workspace.emptyWorkspace.title')}
                            subtitle={translate('workspace.emptyWorkspace.subtitle')}
                            ctaText={translate('workspace.new.newWorkspace')}
                            ctaAccessibilityLabel={translate('workspace.new.newWorkspace')}
                            onCtaPress={() => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt())}
                            illustration={LottieAnimations.WorkspacePlanet}
                            // We use this style to vertically center the illustration, as the original illustration is not centered
                            illustrationStyle={styles.emptyWorkspaceIllustrationStyle}
                        />
                    </View>
                </ScrollView>
            </ScreenWrapper>
        );
    }

What alternative solutions did you explore? (Optional)

We can create a component to show when there is no policy.

Result

subscription_page_not_found.mp4

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a859839633fc1d1d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[mallenexpensify]

@ikevin127 , plz review @Krishna2323 's proposal above.
Also, @ikevin127 @Krishna2323 , assuming the proposal is accepted:

1. Are there other places/links we should update for NotFoundPage surfacing when there's no workspace
2. Do either of you know where 'unvalidated' account discussions are happening? I don't see them on the road map doc. @ikevin127 , I see you reported this which might be similar?

• [HOLD for payment 2024-08-29] [$250] 2FA - No recovery codes in 2FA page for unverified account #43603

[mallenexpensify]

Also... checking here, looks like Niiki and Vivek might be working on unvalidated accounts
https://expensify.slack.com/archives/C049HHMV9SM/p1718648170515479?thread_ts=1718213571.738069&cid=C049HHMV9SM

[ikevin127]

@mallenexpensify The proposal looks good if we can all agree that the expected result here is to show the Create a workspace screen instead of the Not found page. Regarding the 2 points brought up:

1. Not sure, but if we move forward with the proposed solution then I'll make sure to double-check during PR review.
2. Not sure about this either, I think we could test this during PR. I found that issue in a similar fashion (during general testing on a PR review).

Clarifications

Context

The NewFeature issue and PR that introduced this issue:

• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Subscription settings” section (UI) #38626
• feat: Subscription settings UI #42990

Note: The NewFeature issue that implemented the subscription logic was UI focused and the feature is still not available to the user through UI yet.

1. This issue's expected result doesn't make sense since if you're not part of a workspace there shouldn't be content in the subscription page.
2. The only way the subscription page can be reached currently is for the user to paste the https://staging.new.expensify.com/settings/subscription URL and navigate to it manually, there's not button to reach this page.

Question

1. Should we HOLD this issue for when all parts of the NewFeature are deployed and actually made available to the user ? I'm asking this since the the PR author might want to fix this themselves before the feature is actually made available to the user as they mentioned in feat: Subscription settings UI #42990 (comment) regarding follow-up PRs related to any possible issues.

cc @amyevans (❌ OOO) Since she was the CME on both NewFeature issues / PRs.

If we really need to fix this right now, regardless, even though the page is not accessible to the user through UI yet -> then I will move forward with the existing proposal if we can all agree on the expected result proposed by the solution.

[mallenexpensify]

tl,dr: https://staging.new.expensify.com/settings/subscription is throwing an error if you don't have a workspace (but.. you can currently only access via the link so a normal user wouldn't know about). @ikevin127 and I are wondering if this is going to be addressed soon and, if so, how to manage this issue.

Thanks for the detailed digging @ikevin127 . I'm not well-versed in subscription settings details. @trjExpensify @MitchExpensify @blimpich since y'all seem to be part of Build the ability to add and manage your billing card in NewDot

1. Should we put this on hold?
2. If so, what issue or PR should we be holding on?

[blimpich]

I personally don't think this is a concern. We don't show the subscription menu item in the navigation pane unless the user has a subscription already.

I consider this expected behavior. @MitchExpensify feel free to re-open if you feel otherwise.