Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] UX RELIABILITY - Receipt is stuck in a scanning state and the expense fails to load when the IOU preview is tapped #43253

Closed
6 tasks
muttmuure opened this issue Jun 7, 2024 · 12 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2

Comments

@muttmuure
Copy link
Contributor

muttmuure commented Jun 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v1.4.79-7
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1717631386394629

Action Performed:

  1. Open mobile app
  2. Got to new NewDot test workspace chat
  3. tap a IOU request with a receipt scanning in progress
  4. Wait several minutes, nothing loads
  5. Press back
  6. Tap a different IOU request
  7. IOU loads as expected

Expected Result:

The receipt loads immediately

Actual Result:

The loading skeleton loads infinitely

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @davidcardoza
@muttmuure muttmuure added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Jun 7, 2024
@muttmuure muttmuure changed the title [CRITICAL] UX RELIABILITY - Receipt is stuck in a scanning state and the expense fails to load when the IOU preview is tapped HOLD ON PR #43227 [CRITICAL] UX RELIABILITY - Receipt is stuck in a scanning state and the expense fails to load when the IOU preview is tapped Jun 7, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 7, 2024
@muttmuure muttmuure changed the title HOLD ON PR #43227 [CRITICAL] UX RELIABILITY - Receipt is stuck in a scanning state and the expense fails to load when the IOU preview is tapped [CRITICAL] UX RELIABILITY - Receipt is stuck in a scanning state and the expense fails to load when the IOU preview is tapped Jun 11, 2024
@muttmuure
Copy link
Contributor Author

Taking off hold

@muttmuure
Copy link
Contributor Author

Going to ask Doza to try and reproduce

@muttmuure
Copy link
Contributor Author

@davidcardoza I'm going to reassign this to you since it happened in your account.

Can you update to the latest version, turn on client side logs and then try to reproduce this?

@davidcardoza
Copy link
Contributor

davidcardoza commented Jun 12, 2024

I was able to to access the mobile app. I've scanned two receipts, both are still scanning after 6 minutes. I will check back in a few hours.

@tgolen tgolen self-assigned this Jun 14, 2024
@tgolen
Copy link
Contributor

tgolen commented Jun 14, 2024

Note: This PR was released in version 1.4.82-4 yesterday to production. It should contain the additional logs that might help us track this down.

According to the logs I am looking at right now, there is a client here that has a broken sequential queue that keeps growing and never shrinking.

image

I need to get this client updated to at least version 1.4.82-4 of the app so that we can look at the new client logs that we added.

@muttmuure muttmuure added the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Jun 24, 2024
Copy link

melvin-bot bot commented Jun 24, 2024

Current assignee @tgolen is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

@muttmuure muttmuure added AutoAssignerNewDotQuality Used to assign quality issues to engineers and removed AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Jun 24, 2024
@muttmuure muttmuure assigned tgolen and unassigned chiragsalian Jun 24, 2024
@Expensify Expensify deleted a comment from melvin-bot bot Jun 24, 2024
@tgolen
Copy link
Contributor

tgolen commented Jun 24, 2024

I've got a good logsearch query here:

blob:"Darwin/23.5.0" AND (blob:"[SequentialQueue]" OR blob:"[NetworkStatus]" OR blob:"[NetworkConnection]")

Now all I need is a specific window of time to look at. @davidcardoza can you please try a new smart scan and let me know the approximate time (and your timezone) that you made the requests?

@tgolen
Copy link
Contributor

tgolen commented Jun 24, 2024

Weekly Update

  • @marcaaron and I have been looking at client logs and server logs, and think we might have found a problem. (slack)
  • Doza's OpenApp request is timing out (which is the first request that happens when he signs in)
  • I posted this to the #fast-apis channel because there are several open BugBots for the slow query that is happening

Next Steps

  • @tgolen Try to brainstorm some solutions for improving the speed of the query and get someone working on that
  • @tgolen Figure out what front-end changes we can make to better handle a failure such as this

ETA

  • Hard to say, so I'm going to give two weeks to start with.
  • Finished by Friday, July 12

@davidcardoza
Copy link
Contributor

Now all I need is a specific window of time to look at. @davidcardoza can you please try a new smart scan and let me know the approximate time (and your timezone) that you made the requests?

Do you still need this?

@tgolen
Copy link
Contributor

tgolen commented Jun 25, 2024 via email

@muttmuure
Copy link
Contributor Author

Looks like we're done with this one and it's fixed for Doza.

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Reviewing Has a PR in review Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants