[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [REGRESSION] Android & iOS - Track tax - "Track tax" message does not scale according to device font size

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.80-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #42141

Action Performed:

Precondition:

• Device font size is minimum (or smaller than the standard size)
• Workspace has not enabled taxes

1. Launch New Expensify app
2. Go to workspace settings
3. Go to Distance rates
4. Tap Settings

Expected Result:

"Track tax" message will scale according to device font size

Actual Result:

"Track tax" message does not scale according to device font size.
It appears large when the rest of the font is small

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6504145_1717692057007.RPReplay_Final1717691715.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016209fd348bb29320
• Upwork Job ID: 1798774655174697872
• Last Price Increase: 2024-06-06
• Automatic offers:
• nkdengineer | Contributor | 102637502

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016209fd348bb29320

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[AndrewGable]

Not a deploy blocker, seems like it can be external for sure

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track tax - "Track tax" message does not scale according to device font size

What is the root cause of that problem?

We have extra text styles causing this behavior:

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Line 128 in 01c418d

<Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.distanceRates.trackTax')}</Text>

What changes do you think we should make in order to solve the problem?

We will remove the styles from the Text element here:

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Line 128 in 01c418d

<Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.distanceRates.trackTax')}</Text>

This would also align the style with the Figma mockups, since colorMuted is also not needed here

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android & iOS - Track tax - "Track tax" message does not scale according to device font size.

What is the root cause of that problem?

Font size is fixed to 14.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Line 141 in 1f3658c

fontSize={14}

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Line 145 in 1f3658c

fontSize={14}

Hence, scaling font doesn't have any effect.

What changes do you think we should make in order to solve the problem?

Font size needs to be removed:

{!isPolicyTrackTaxEnabled && (
    <View style={[styles.mh4]}>
        <Text
            style={styles.colorMuted}
        >
            {translate('workspace.distanceRates.taxFeatureNotEnabledMessage')}
            <TextLink
                onPress={() => {
                    Navigation.dismissModal();
                    Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID));
                }}
            >
                {translate('workspace.common.moreFeatures')}
            </TextLink>
            {translate('workspace.distanceRates.changePromptMessage')}
        </Text>
    </View>
)}

What alternate solution did you consider?

We might want to use something like variables.fontSizeLabel instead of setting to 14. Can be discussed with design team.

[ShridharGoel]

Proposal

Updated

[melvin-bot]

📣 @CharlsSH! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Chavas950906]

Contributor details
Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~017390385257472222

[Chavas950906]

How can i help you?

[rojiphil]

Unassigned as this is regression and will be fixed by the original authors. Please feel free to add me if needed.

[Chavas950906]

So How do I do?

[jliexpensify]

Thanks for your help here @rojiphil!

@CharlsSH @ShridharGoel - this issue was created due to a regression so it is the responsibility of the original PR's Contributor and C+ to handle this regression. It looks like the External label was applied before I got online, so I apologise for the confusion.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[kavimuru]

Issue fixed

RPReplay_Final1717786049.MP4

[jliexpensify]

Awesome, thank you! Closing this one out.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix distance tax regression #43246

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix distance tax regression #43246

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: