[$250] IOS - Chat - Show error when access start chat 2nd time in off-mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.78-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #42679

Action Performed:

1. Go offline
2. Create a new room from FAB
3. Open the new room page again from FAB

Expected Result:

Can start a new chat

Actual Result:

Show error when access starts to chat 2nd time in off-mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6496979_1717125695227.RPReplay_Final1717123192__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0136e2911a526a72fe
• Upwork Job ID: 1797891905991876608
• Last Price Increase: 2024-06-18

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0136e2911a526a72fe

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show error when access starts to chat 2nd time in offline mode

What is the root cause of that problem?

• The root cause for the crash is explained here
• After the crash is fixed, when trying to create the room the second time, the modal will be automatically dismissed, the root cause is in

  App/src/pages/workspace/WorkspaceNewRoomPage.tsx

  Line 129 in 1d5f83d

  Report.clearNewRoomFormError();

  , the app is clearing the form loading state only when it's mounted. When the loading state is initially true, it already causes the modal to be dismissed in here, before the "clear isLoading" useEffect finishes running.

What changes do you think we should make in order to solve the problem?

• The crash will be fixed by this proposal in another issue

• The modal automatically dismissed issue can be fixed by clearing the isLoading when the component is unmounted too (or can change to clearing when the screen is focused/loses focus)

useEffect(() => {
    Report.clearNewRoomFormError();

    return () => {
        Report.clearNewRoomFormError();
    }
}, []);

Or clearing whenever we call Navigation.dismissModal in the page should also be ok

What alternative solutions did you explore? (Optional)

For the second issue, we can remove this block and the related error clearing logic entirely. They were meant to support the use case that there's a duplicate room name error thrown from the back-end, but we have the front-end validation logic for that in

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Line 179 in 1d5f83d

} else if (ValidationUtils.isExistingRoomName(values.roomName, reports, values.policyID ?? '')) {

already so that block is no longer needed.

And we already have the dismissModal logic after the user creates the room here

App/src/libs/actions/Report.ts

Line 2102 in 1d5f83d

Navigation.dismissModalWithReport(policyReport);

[dominictb]

Proposal updated to add the fix for another observed issue

[badeggg]

@dominictb Hi, do you know why setIsInputInitialized(true); is called many times in iOS when offline? I can not find out

[bernhardoj]

Same crash root cause as #42824

[badeggg]

Proposal

Same root cause with #42824, same proposal

[dominictb]

Proposal updated to emphasize that 1 part of the issue will be fixed in #42824

[melvin-bot]

@abdulrahuman5196, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kadiealexander]

@abdulrahuman5196 bump!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[kadiealexander]

Hey @ishpaul777 could you please review the proposals here? Thank you!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ishpaul777]

Reviewing! 👀

[ishpaul777]

hmm it appears that this issue partially be fixed by #42824 @kadiealexander Can we please put a HOLD and then retest if there's any other issue left for us to fix.

[melvin-bot]

@kadiealexander @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[ishpaul777]

Holding PR for this is deployed. do we still have any issues left to fix @dominictb ? if yes, please share videos/steps Thanks!

[kadiealexander]

Requested a retest here

[kbecciv]

Issue is no longer reproduce!

RPReplay_Final1718720116.MP4

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ishpaul777]

just want to make sure, @dominictb would you like to report any related issue left to fix here ? if no, i think we are good to close this @kadiealexander