[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Track Tax] Distance tax - Tax amount is zero when distance rate with non-zero tax rate is selected

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.77-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #42342

Action Performed:

Precondition:

• Track Tax distance is enabled on Old Dot.
• Workspace has a few distance rates and tax rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Open submit distance expense flow
4. Proceed to distance expense confirmation page
5. Click Distance rate
6. Select a distance rate that has non-zero tax rate
7. Note that tax amount is updated after selecting a distance rate
8. Submit the expense
9. Go to transaction thread

Expected Result:

The tax amount in the transaction thread will follow the amount based on the distance rate, which is the same amount on confirmation page

Actual Result:

The tax amount in the transaction thread changes to 0.00 after the expense is created

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495196_1716993750281.20240529_223703.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@chiragsalian FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[MonilBhavsar]

Looking...

[MonilBhavsar]

I'm not able to reproduce this issue. @lanitochka17 could you please help to retest

[kbecciv]

Issue is reproducible, please try to wait until Distance is no longer pending.

bandicam.2024-05-30.23-32-31-593.mp4

[luacmartins]

It seems like the API response is updating the amount to 0. Is this a Web deploy blocker?

[MonilBhavsar]

I also have same suspicion. Unfortuanately my requests are getting timed out, so I haven't been able to confirm https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=10000&query=request_id%3A%2288bfe11aba9489fc-BOM%22%20AND%20timestamp%3A%5B2024-05-30T00%3A00%20TO%202024-05-31T23%3A59%5D

But there is no new code deployed to staging related to this flow, so it's not a Web-E blocker

[MonilBhavsar]

Finally succeeded.

I am still not able to reproduce, I waited till the distance was populated

Recording https://drive.google.com/file/d/1j8ZTxJzLTdoguUEzflSZPBagw4FYBZxw/view?usp=sharing

Anyways, this should not block deploy and can be treated as a bug, if reproducible. I'll assign myself and look

[MonilBhavsar]

Retried again and still no dice

[MonilBhavsar]

Tom is helping to check if it's a real bug

[trjExpensify]

1. I have selected the Standard tax rate for distance expenses:

2. The default tax rate for expenses in the workspace currency is the EC rate here:

3. The distance expense is using the workspace default rate and not the tax rate set for distance expenses:

So I think the bug is that we're using the workspace default tax rate and not the tax rate set for the distance rate. 👍

[MonilBhavsar]

Will start working tomorrow

[MonilBhavsar]

PR is in review

[MonilBhavsar]

assigning @hungvu193 for helping with PR review

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix incorrect tax rate selected with distance rate #43052

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment (Needs manual offer from BZ)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix incorrect tax rate selected with distance rate #43052

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment (Needs manual offer from BZ)

[trjExpensify]

👋 can we confirm on this deploy blocker being a regression for this issue? #42802 (comment)

[hungvu193]

No. I think @MonilBhavsar already commented on the DB here:

#43171 (comment)

That DB was caused by another PR.

[MonilBhavsar]

Yes, it was not a regression from this PR

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @hungvu193 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

Great! Payment summary as follows:

• $250 to @hungvu193 for the C+ review

Offer sent!

[hungvu193]

Great! Payment summary as follows:

• $250 to @hungvu193 for the C+ review

Offer sent!

Thanks Tom. I've just accepted!

[trjExpensify]

Paid, closing!