Tax - Split scan - Selected tax rate is duplicated in Tax rate list

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when validating #40240
Version Number: 1.4.76-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• Workspace is tax enabled.
• Workspace currency default and Foreign currency default have different tax rate in workspace tax settings.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create a split scan.
4. When the receipt is scanning, click on the split preview.
5. Click Amount.
6. Change the currency to foreign currency.
7. Enter amount and save it.
8. Click Tax rate.

Expected Result:

The selected tax rate will not be duplicated.

Actual Result:

The selected tax rate is duplicated.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6493019_1716821848213.20240527_225309.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[blimpich]

Looking into this

[blimpich]

I don't think this is worth blocking the deploy, demoting.

[blimpich]

@MonilBhavsar I think this is related to #40240. Do you want to take this over? Otherwise I think we can just open this up to contributors.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Duplicated tax rate in the tax rate list

What is the root cause of that problem?

when we update the split transaction, we save the data in splitDraftTransaction. However, we consistently rely on transaction in the TaxPicker Component

What changes do you think we should make in order to solve the problem?

In the TaxPicker, we need to implement a logic similar to what we've done in the IOURequestStepTaxRatePage

App/src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx

Line 60 in 95d328f

const currentTransaction = isEditingSplitBill && !isEmptyObject(splitDraftTransaction) ? splitDraftTransaction : transaction;

When isEditingSplitBill is true, we should utilize splitDraftTransaction instead of transaction

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[cretadn22]

@blimpich This seems somewhat connected to #40240, but I don't believe it is a regression

cc @MonilBhavsar

[blimpich]

@cretadn22 if this wasn't caused by #40240 then what did cause this? Please explain why you think this specifically isn't a regression

[bondydaa]

the revert #42670 has been deployed, please retest and confirm this is no longer reproducible.

[blimpich]

cc: @m-natarajan, can you see if this still reproduces?

[kavimuru]

This bug is not reproducible

[Christinadobrzyn]

I also can't reproduce this issue. I think we can close this. Feel free to let me know if I'm missing anything!

[MonilBhavsar]

I think we should pay @cretadn22 $100(May be $125 i.e. 50% of our usual bounty) for investigating the root cause of this and other related issues.
I think it helped to revert the PR in timely manner and move forward with the deploy. Also it saved me some time fixing the bugs in a follow up PR. cc @Christinadobrzyn @blimpich @bondydaa

Comments:
#42642 (comment)
#42649 (comment)
#42652 (comment)
#42655 (comment)

[cretadn22]

@MonilBhavsar Thank you for your recognition of my efforts. After proposing solutions for 4 blockers, it appears they were implemented in the subsequent pull request. Could I suggest raising the bounty to $250 for the effort put into investigating and suggest solutions for those blockers? It seems more fitting than the current $125, which is only half the base price for an issue.

[Christinadobrzyn]

checking with @MonilBhavsar on your request @cretadn22

[MonilBhavsar]

I can't think of a reason why we should not. So I'm fine with paying it. Fine with what others has to say 👍

[blimpich]

Sounds good to me 👍

@Christinadobrzyn can we pay out $250 to @cretadn22 and then close this issue?

[Christinadobrzyn]

Yep! Payouts due:

• Contributor: $250 @cretadn22 (Paid in Upwork - https://www.upwork.com/nx/wm/offer/102634283)

Upwork job is here.

@cretadn22 can you accept? TY!

[cretadn22]

@Christinadobrzyn Done 🙏 Thanks so much

[cretadn22]

Awaiting payment from @Christinadobrzyn

[Christinadobrzyn]

Thanks @cretadn22 - Paid out based on this payment summary - #42642 (comment)

Closing!