[PAID] Tax - Tax rate and tax amount does not update when switching currency offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.73-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace has enabled tax rate.
• Workspace currency default and Foreign currency default are different.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go offline.
4. Submit an expense in local currency.
5. Go to transaction thread.
6. Click Amount and change it to a foreign currency.

Expected Result:

When changing currency from local to foreign offline, the tax rate and tax amount will update accordingly.

Actual Result:

When changing currency from local to foreign offline, the "Default" label moves to Foreign currency default, but tax rate and tax amount does not update.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6479176_1715595256779.tax_offline.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

Recording.2450.mp4

[MonilBhavsar]

Looking at this...

[MonilBhavsar]

on HOLD for #42064
We need to use some code from #42064
Working on the PR

[MonilBhavsar]

PR is being reviewed

[MonilBhavsar]

Tested on staging and works fine!!

Screen.Recording.2024-05-15.at.12.45.17.PM.mov

[MonilBhavsar]

@rojiphil needs to be compensated for PR review and testing cc @strepanier03

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix tax rate being updated when currency is updated in offline mode #42128

If no regressions arise, payment will be issued on 2024-05-22. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil - $250 via Upwork (offer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR:
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rojiphil] Determine if we should create a regression test for this bug.
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

@rojiphil - Pay hold comes off tomorrow. I've sent you an offer in Upwork so feel free to finish up the checklist as soon as you're ready.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @rojiphil paid $250 via Upwork (LINK)

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[rojiphil]

• [@rojiphil] The PR that introduced the bug has been identified. Link to the PR: Offending PR
• [@rojiphil] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Added comment
• [@rojiphil] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required. Existing checklist good enough to capture such issues.
• [@rojiphil] Determine if we should create a regression test for this bug. : A faulty tax rate and amount can result in financial loss to stakeholders. So, it would be better to have a regression test for this.
• [@rojiphil] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • Workspace has enabled tax rate.
  • Workspace currency default and Foreign currency default are different.
  1 Go to workspace chat.
  2 Submit an expense in local currency.
  3 Go to transaction thread.
  4 Click Amount and change it to a foreign currency.
  Expected Result: The tax rate should change to that of the default foreign currency and the tax amount should also be updated accordingly.

[rojiphil]

I've sent you an offer in Upwork so feel free to finish up the checklist as soon as you're ready.

@strepanier03 Accepted offer and completed checklist here

[strepanier03]

Thanks @rojiphil - Working on this now.

[strepanier03]

Created the reg test GH. Paid out and closed the contract in Upwork. Thanks everyone!