Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-24] [$250] [Uneven Splits] [Polish] Android - Split amount is not reset when tapping Reset button when keyboard is up #41763

Closed
2 of 6 tasks
m-natarajan opened this issue May 7, 2024 · 78 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented May 7, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.71-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Go to FAB > Split expense.
  3. Enter amount and select a few users.
  4. Tap on split amount input.
  5. Manually enter the split amount.
  6. With keyboard up, tap on Reset button.

Expected Result:

The split amount will be reset (mweb behavior when keyboard is up).

Actual Result:

The keyboard is dismissed and the split amount is not reset.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6473732_1715085745394.Screen_Recording_20240507_203613_New_Expensify__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010af563a3cc74c7c2
  • Upwork Job ID: 1787911203897004032
  • Last Price Increase: 2024-05-28
Issue OwnerCurrent Issue Owner: @alexpensify
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 7, 2024
Copy link

melvin-bot bot commented May 7, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 7, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@m-natarajan
Copy link
Author

We think this bug might be related to #vip-split

@rlinoz
Copy link
Contributor

rlinoz commented May 7, 2024

This is related to the new uneven split feature #40386

I don't think this needs to be a blocker, as the reset feature still works, but curious for @youssef-lr's thoughts.

Also, are you taking this issues or should I make it external?

@kbecciv kbecciv added the DeployBlocker Indicates it should block deploying the API label May 7, 2024
@youssef-lr youssef-lr added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 7, 2024
@melvin-bot melvin-bot bot changed the title Android - Split - Split amount is not reset when tapping Reset button when keyboard is up [$250] Android - Split - Split amount is not reset when tapping Reset button when keyboard is up May 7, 2024
Copy link

melvin-bot bot commented May 7, 2024

Job added to Upwork: https://www.upwork.com/jobs/~010af563a3cc74c7c2

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 7, 2024
@youssef-lr youssef-lr assigned youssef-lr and unassigned rlinoz May 7, 2024
Copy link

melvin-bot bot commented May 7, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@youssef-lr
Copy link
Contributor

Thanks @amyevans, let's open this up for contributors as I haven't been able to figure it out yet and don't have time to do so.

@isabelastisser isabelastisser removed the Bug Something is broken. Auto assigns a BugZero manager. label Jul 18, 2024
@isabelastisser isabelastisser removed their assignment Jul 18, 2024
@isabelastisser isabelastisser added the Bug Something is broken. Auto assigns a BugZero manager. label Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 18, 2024
@isabelastisser isabelastisser removed their assignment Jul 18, 2024
@isabelastisser isabelastisser added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@isabelastisser
Copy link
Contributor

isabelastisser commented Jul 18, 2024

I will be OOO tomorrow and next week, so I am reassigning this until I return on July 29. Thanks, @alexpensify

Status:

  • @eVoloshchak needs to complete the BZ list.
  • Payment is due on July 24.

@alexpensify
Copy link
Contributor

Noted, I'll prepare next week for the payment date.

@melvin-bot melvin-bot bot added the Overdue label Jul 22, 2024
@alexpensify
Copy link
Contributor

Not overdue, the payment date is on the 24th.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Daily KSv2 labels Jul 22, 2024
Copy link

melvin-bot bot commented Jul 24, 2024

Payment Summary

Upwork Job

BugZero Checklist (@alexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1787911203897004032/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@alexpensify
Copy link
Contributor

Correct me if I'm wrong, but it looks like there is another PR in the works associated with this GH: #45333. I'm going to hold off on completing the payment action until all PRs are in production.

@kaushiktd - please apply here:
https://www.upwork.com/jobs/~016c93f917170cbc76

Thanks!

@alexpensify alexpensify added Weekly KSv2 and removed Daily KSv2 labels Jul 24, 2024
@kaushiktd
Copy link
Contributor

@alexpensify Is it possible for you to send me an invitation to that job?

@alexpensify
Copy link
Contributor

@kaushiktd - I sent an invite via Upwork. Please accept and I can complete the payment process. Thanks!

@kaushiktd
Copy link
Contributor

Thank you @alexpensify

I accepted the offer.

@alexpensify
Copy link
Contributor

Done - I've completed the payment process in Upwork

#41763 (comment)

@eVoloshchak - please submit a request in Chat, thanks!

@isabelastisser
Copy link
Contributor

Thanks for handling this, @alexpensify!

@alexpensify
Copy link
Contributor

You're welcome! @isabelastisser there is no more action to take here.

@eVoloshchak - please submit a request in Chat. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants