[PAYMENT MAY 29][$250] Split - Expense text is missing from the preview tile when creating split expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.66.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #40961

Action Performed:

1. Navigate to a group chat
2. Do a manual split there
3. Use the quick action button to do another split

Expected Result:

Expense text should be visible

Actual Result:

Expense text is missing from the preview tile when creating split expense. It's visible if you use the quick action button to do the same split

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cb074043a26909ea
• Upwork Job ID: 1785399966337712128
• Last Price Increase: 2024-04-30
• Automatic offers:
• s77rt | Reviewer | 0
• gijoe0295 | Contributor | 0

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense text is missing from the preview tile when creating split expense. It's visible if you use the quick action button to do the same split

What is the root cause of that problem?

The Expense text is the transaction's merchant.

For quick action, we skip the confirmation screen and pass merchant as empty:

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 193 in 08d8735

merchant: '',

while in confirmation screen (split without quick action), merchant is (none) which was initiated here.

For the first case, merchant is eventually evaluated to Expense while kept as (none) for the second case:

App/src/libs/actions/IOU.ts

Line 3140 in 2b0b12c

merchant || Localize.translateLocal('iou.expense'),

That's why splitting through QAB has Expense merchant while normal split does not.

What changes do you think we should make in order to solve the problem?

There are 2 options:

1. Keep Expense for both cases

I think in general we fallback to Expense for bill split transactions if merchant was empty in createSplitsAndOnyxData.

App/src/libs/actions/IOU.ts

Line 3140 in 2b0b12c

merchant || Localize.translateLocal('iou.expense'),

const isMerchantEmpty = !merchant || merchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT

...

merchant: isMerchantEmpty ? Localize.translateLocal('iou.expense') : merchant

2. Do not show Expense for both cases

That means we fallback to (none).

merchant: merchant || CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@slafortune Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cb074043a26909ea

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@gijoe0295 Thanks for the proposal. Your RCA makes sense. Let's align on the expected behavior and discuss the solution.

🎀 👀 🎀 The expected behavior is not clear, when creating a split should we:

1. Set the merchant to "Expense"
2. Keep the merchant empty

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[gijoe0295]

@thienlnam Could you check for assignment please?

[melvin-bot]

@slafortune, @s77rt, @thienlnam Eep! 4 days overdue now. Issues have feelings too...

[s77rt]

@thienlnam Can you please check #41010 (comment)

[melvin-bot]

@slafortune @s77rt @thienlnam this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[slafortune]

@thienlnam when you get a chance can you review the assignment?

[melvin-bot]

@slafortune, @s77rt, @thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[thienlnam]

Ah yes, thanks for the bump - was OOO last week

[thienlnam]

We would want to keep the merchant empty

[s77rt]

@gijoe0295 Let's just change the merchant value to CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Line 204 in c5bf798

merchant: '',

[slafortune]

This was merged yesterday -

That would make the payment on the 29th - looks like the title didn't update.

@s77rt - C+ Role ~ will be due $250 via Upworks
@gijoe0295 - Contributor Role ~ will be due $250 via Upworks

I'll be on vacation until June 4th so adding a BZ in the meantime.

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[garrettmknight]

Payment Summary:
@s77rt - C+ Role - $250 paid via upwork
@gijoe0295 - Contributor Role - $250 paid via upwork

[garrettmknight]

@s77rt can you complete the checklist when you get a chance?

[s77rt]

• The PR that introduced the bug has been identified: Skip confirmation page for Quick Actions #39413
• The offending PR has been commented on: Skip confirmation page for Quick Actions #39413 (comment)
• A discussion in #expensify-bugs has been started: Not needed (unique bug)
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

1. Click on FAB
2. Click on Split expense
3. Split the expense with an individual without specifying the merchant
4. Click on the split preview
5. Verify that the merchant field is empty
6. Click on FAB
7. Verify that the QAB reflects the split option
8. Click on the QAB
9. Verify that the split expense flow opens
10. Submit the expense
11. Click on the split preview
12. Verify that the merchant field is empty

suggested test suite group

[s77rt]

@garrettmknight Done! ^

[garrettmknight]

Legend, thank you!