[HOLD for payment 2024-06-06] [Guided Setup] [$250] Login - "Here is your magic code" appears briefly before the abracadabra page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.61.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4481382&group_by=cases:section_id&group_id=229043&group_order=asc
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Start logging in with a new Gmail account
2. Copy the magic link, paste it to iCloud notes and add "staging" to it
3. Open it from iCloud notes

Expected Result:

Only the abracadabra page should show.

Actual Result:

"Here is your magic code" appears briefly before the abracadabra page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6442666_1712601744345.WFOT6467.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01505b69dbb8511b47
• Upwork Job ID: 1777673648903905280
• Last Price Increase: 2024-04-09
• Automatic offers:
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @lakchote

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

Production

RPReplay_Final1712651021.MP4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01505b69dbb8511b47

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[lakchote]

Similar issue here.

Seems to be a regression from #37733

cc @eVoloshchak @MaciejSWM

[parasharrajat]

How do we want to handle this @lakchote? Looks for a proposal or ask original author to solve it.

[lakchote]

How do we want to handle this @lakchote? Looks for a proposal or ask original author to solve it.

I'm open to fixing this as soon as possible in a correct way. We should not revert the offending PR as per the comment here.

I've asked @mountiny on how to handle this, as we've got no proposals. I've already tagged the original author in this PR.

I'll update whenever I have new info.

[lakchote]

Since the user user can sign in normally, and the problem is more that a flash of text appears, I'm going to remove the Deploy blocker label.

[mountiny]

Thanks, I agree this does not have to be a blocker

[Julesssss]

Agree, thank you

[trjExpensify]

What's the latest here? This has been in review for a while at this point.

[bernhardoj]

Waiting for @parasharrajat testing.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix here is your magic code shows briefly when login with magic link #40766

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

@bernhardoj payment made!

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: This happens due to delay in updation of signing state.
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Test with 2FA enabled

Web/mWeb/Desktop

1. Log out
2. Enter your account which has 2fa enabled login and press Next
3. Open the magic code email
4. Copy the magic link
5. Append staging. to the magic link and open it on another tab
6. Verify after the splash screen, you see a loading indicator
7. Wait until it loads completely
8. Verify you see the 2FA required page
9. Verify the loading indicator isn't visible

Test without 2FA

Web/mWeb/Desktop

1. Log out
2. Enter any login and press Next
3. Open the magic code email
4. Copy the magic link
5. Append staging. to the magic link and open it on another tab
6. Verify after the splash screen, you see a loading indicator
7. Wait until it loads completely
8. Verify you see the Abracadabra page

Do you agree 👍 or 👎 ?

[adelekennedy]

Payouts due:

• Contributor: $250 @bernhardoj (Upwork)
• Contributor+: $250 @parasharrajat (NewDot)

Upwork job is here.

[adelekennedy]

@lakchote to review the regression test steps above!

[melvin-bot]

@lakchote, @parasharrajat, @bernhardoj, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@lakchote, @parasharrajat, @bernhardoj, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[adelekennedy]

I completely forgot @lakchote is on parental leave - I think the regression steps make sense so moving forward with creating the GH

[parasharrajat]

Payment requested as per #39904 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat