[$250] Add support for viewing full screen Group Chat custom avatars

[marcaaron]

Problem

When we added support for custom Group Chat avatars there are some places left where we cannot yet view the full screen avatar.

Solution

Navigate to the correct page like we do here when user taps on the avatar:

App/src/components/RoomHeaderAvatars.tsx

Lines 19 to 28 in ddb83f2

	function RoomHeaderAvatars({icons, reportID, isGroupChat}: RoomHeaderAvatarsProps) {
	const navigateToAvatarPage = (icon: Icon) => {
	if (isGroupChat) {
	return;
	}
	if (icon.type === CONST.ICON_TYPE_WORKSPACE) {
	Navigation.navigate(ROUTES.REPORT_AVATAR.getRoute(reportID));
	return;
	}

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c10e84b6d429f37d
• Upwork Job ID: 1785082381325901824
• Last Price Increase: 2024-04-29
• Automatic offers:
• s77rt | Reviewer | 0
• tsa321 | Contributor | 103805311

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @zanyrenney

[s77rt]

No progress yet. Focused on QBO

[dannymcclain]

I think ideally we'd follow the same pattern that we use for custom workspace avatars.

cc @Expensify/design - I actually think the order of these should be Upload, View, Remove. But that's not a super pressing concern.

[marcaaron]

Hey @s77rt, let us know if you have started working on this. I can make it external, but would love if you could be the C+ still.

[shawnborton]

I agree with the proposed solution from Danny.

[s77rt]

@marcaaron Making this External sounds good to me. I'd love to be the C+ still

[melvin-bot]

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c10e84b6d429f37d

[melvin-bot]

Current assignee @marcaaron is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

@s77rt, @marcaaron, @zanyrenney, @dubielzyk-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dubielzyk-expensify]

Not overdue

[zanyrenney]

I'm not clear what we're waiting on here. Mind confirming how come this isn't overdue @dubielzyk-expensify or what we're waiting on @s77rt ? Thanks!

[s77rt]

Waiting on @marcaaron to review and assign @tsa321 for his proposal based on #39850 (comment)

[melvin-bot]

📣 @tsa321 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[marcaaron]

Just assigned Melv.

[melvin-bot]

This issue has not been updated in over 15 days. @s77rt, @marcaaron, @zanyrenney, @tsa321, @dubielzyk-expensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[s77rt]

PR was deployed to production 2 weeks ago. This is ready for payment cc @zanyrenney

[zanyrenney]

payment summary

paid @s77rt $250 via upwork
paid @tsa321 $250 via upwork.

Thanks 👋🏼

[s77rt]

I have refunded 50% for the regressions (there were 2 but both found at same period and one of them was due to a "feature" that we just removed)