[payment DUE] [$250] Don't show GBR to AM/guides for managed customer employee invitations

[joekaufmanexpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue reported by: @joekaufmanexpensify / @greg-schroeder
Slack conversation: https://expensify.slack.com/archives/C03U7DCU4/p1709891758477419

Action Performed:

1. Expensify account manager/guide is added to customer's workspace to assist them.
2. Employee requests to join workspace.

Expected Result:

Account manager/guide should not have the workspace join request pinned to their LHN, since they are not a part of the company, and should not action it on their behalf.

Actual Result:

Account manager/guide has the workspace join request pinned to their LHN as GBR.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b0c3b670623a55c2
• Upwork Job ID: 1775996355860926464
• Last Price Increase: 2024-04-11
• Automatic offers:
• Pujan92 | Reviewer | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b0c3b670623a55c2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[joekaufmanexpensify]

Another proposal here is to make an explicit AM/guide an explicit workspace role. Which could be the better long term solution

[twisterdotcom]

I am a huge fan of doing whatever needs to be done to fix this quickly and for now. This is just causing super high annoyance and noise for me and every single person on our Sales and Account Management team.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Account manager gets report shown as having a new join request in LHN.

What is the root cause of that problem?

The current logic doesn't check if the user is an account manager before pinning and marking as unread + showing the green dot.

if (ReportActionsUtils.isActionableJoinRequestPending(report.reportID)) {
    result.isPinned = true;
    result.isUnread = true;
    result.brickRoadIndicator = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
}

What changes do you think we should make in order to solve the problem?

We can add a check to not show as pinned, unread and green dot if the user is from Expensify team.

if (ReportActionsUtils.isActionableJoinRequestPending(report.reportID) && !PolicyUtils.isExpensifyTeam(personalDetail?.login)) {
    result.isPinned = true;
    result.isUnread = true;
    result.brickRoadIndicator = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
}

We might also need to add another condition: if the owner is from Expensify team, then we can show as pinned, unread and with green dot for Expensify accounts also because that might mean that the workspace belongs to Expensify itself.

The above is something that needs discussion.

Code is this situation can be:

if (ReportActionsUtils.isActionableJoinRequestPending(report.reportID)) {
    if (PolicyUtils.isExpensifyTeam(personalDetail?.login) && !PolicyUtils.isExpensifyTeam(result.ownerEmail)) {
        return;
    }
    result.isPinned = true;
    result.isUnread = true;
    result.brickRoadIndicator = CONST.BRICK_ROAD_INDICATOR_STATUS.INFO;
}

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Account manager/guide has the workspace join request pinned to their LHN as GBR.

What is the root cause of that problem?

We already have a method isJoinRequestInAdminRoom to check whether to show GBR here, but currently don't prevent Expensify AM/guides from seeing the GBR from customer workspace's employee invitations.

What changes do you think we should make in order to solve the problem?

In isJoinRequestInAdminRoom here, if we check that the currentUserPersonalDetails belongs to an Expensify team member, and the policy is not created by an Expensify team member (meaning the policy belongs to the customer). Then we can early return false to avoid distractions to Expensify team member.

if (report.policyID) {
    const policy = getPolicy(report.policyID);
    if (!PolicyUtils.isExpensifyTeam(policy.owner) && PolicyUtils.isExpensifyTeam(currentUserPersonalDetails?.login ?? currentUserPersonalDetails?.displayName)) {
        return false;
    }
}

In here, we can also change to use the isJoinRequestInAdminRoom for consistency

if (ReportUtils.isJoinRequestInAdminRoom(report)) {

The above is similar logic to what we already do here to decide whether to show the Expensify team member as workspace member.

To make this more robust, we can pass the necessary data like policy down to the isJoinRequestInAdminRoom from the caller instead of getting it from cached value.

The earlier suggested proposal won't work because the LHN GBR logic is not there.

What alternative solutions did you explore? (Optional)

NA

[Pujan92]

@joekaufmanexpensify @greg-schroeder I think this should be internal as we can't reproduce/test this because it requires AM/guide or expensify account.

[ShridharGoel]

@Pujan92 It can be tested by hardcoding the email ID.

[ShridharGoel]

But yeah, we'll need to login to test. Is there any test ID with expensify domain?

[Pujan92]

At the moment I am facing an issue with inviting a user with the workspace join link and seems to be a regression from here.

[Pujan92]

But yeah, we'll need to login to test. Is there any test ID with expensify domain?

I don't think so but let @joekaufmanexpensify confirm.

[joekaufmanexpensify]

I am a huge fan of doing whatever needs to be done to fix this quickly and for now. This is just causing super high annoyance and noise for me and every single person on our Sales and Account Management team.

@twisterdotcom Totally fair. I think the better long term solution is to create a new user role on workspaces for guides/AMs. Not sure how much additional work it is relative to just changing the behavior of these messages (though I assume it is some). If it's a lot more work, perhaps we could just change this now, and then open a follow up issue to explore the new user-role more holistically.

[joekaufmanexpensify]

But yeah, we'll need to login to test. Is there any test ID with expensify domain?

@Pujan92 @ShridharGoel could you clarify what test ID is referring to here?

[ShridharGoel]

@joekaufmanexpensify I meant a test account with Expensify domain which we can use to login.

[melvin-bot]

@Pujan92, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[joekaufmanexpensify]

Got it. Hmm, yeah I don't think we have a test expensify.com account that you could test with at this time.

[twisterdotcom]

Can we just push it and have somebody test on staging?

[Pujan92]

Can we just push it and have somebody test on staging?

Yes, that is doable.

[zanyrenney]

how is the PR review going @nkdengineer @Pujan92

[Pujan92]

Waiting for @marcochavezf to review the comment #39659 (comment)

[marcochavezf]

Thanks for the review @Pujan92, assigning @nkdengineer

[melvin-bot]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@Pujan92 The PR is here.

[Pujan92]

@zanyrenney Seems automation is broken here, payment is due now.

[Pujan92]

Bump @zanyrenney :)

[zanyrenney]

Seems liks there might be an issue here - When I click the offer link in the GH issue, it seems like it doesn't exist.

[Pujan92]

@zanyrenney The Offer has already been accepted, Plz check this Upwork job link

[zanyrenney]

I know - It's paid for you @Pujan92

I am waiting for @nkdengineer to accept.

[zanyrenney]

bump @nkdengineer

[nkdengineer]

@zanyrenney Invitation accepted! Sorry for the delay 🙏

[zanyrenney]

Dm @nkdengineer need him to accept offer.

[zanyrenney]

https://expensify.slack.com/archives/C01GTK53T8Q/p1716203310396389

[nkdengineer]

@zanyrenney Offer accepted!

[zanyrenney]

payment summary

paid @nkdengineer $250 via upwork
paid @Pujan92 $250 via upwork