[HOLD for payment 2024-04-15] [$500] IOU - Multiline IOU description from 1:1 DM in LHN is not truncated

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to 1:1 DM with user that has no unsettled IOU.
3. Create a money request with multiline description.

Expected Result:

The 1:1 DM preview in LHN will show truncated IOU description.

Actual Result:

Multiline IOU description from 1:1 DM in LHN is not truncated.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435827_1712078095418.20240403_011039.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d08ecf7ecf737a6d
• Upwork Job ID: 1775285976769712128
• Last Price Increase: 2024-04-02
• Automatic offers:
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[chiragsalian]

Tossing it to external to help find the source of the issue sooner since I'm not looking at this for the next few hours. if there hasn't been any progress I'll work on it later.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d08ecf7ecf737a6d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The chat report LHN subtitle shows as multiline when having a money request with multi line description.

What is the root cause of that problem?

The LHN subtitle when there is a report preview is taken from this logic.

App/src/libs/OptionsListUtils.ts

Lines 541 to 558 in 6463de6

	} else if (ReportActionUtils.isReportPreviewAction(lastReportAction)) {
	const iouReport = ReportUtils.getReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(lastReportAction));
	const lastIOUMoneyReportAction = allSortedReportActions[iouReport?.reportID ?? '']?.find(
	(reportAction, key) =>
	ReportActionUtils.shouldReportActionBeVisible(reportAction, key) &&
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
	ReportActionUtils.isMoneyRequestAction(reportAction),
	);
	lastMessageTextFromReport = ReportUtils.getReportPreviewMessage(
	!isEmptyObject(iouReport) ? iouReport : null,
	lastIOUMoneyReportAction,
	true,
	ReportUtils.isChatReport(report),
	null,
	true,
	lastReportAction,
	);
	} else if (ReportActionUtils.isReimbursementQueuedAction(lastReportAction)) {

getReportPreviewMessage has lots of logic inside it, but in our case, it returns {payer} owes {amount} for {description}. If the description is multi-line, the LHN will show it as multi-line too. This doesn't happen if we open the IOU report because in IOU report, the action is a money request action, and for money request action we already handle the multiline by using formatReportLastMessageText.

App/src/libs/OptionsListUtils.ts

Lines 538 to 541 in 6463de6

	} else if (ReportActionUtils.isMoneyRequestAction(lastReportAction)) {
	const properSchemaForMoneyRequestMessage = ReportUtils.getReportPreviewMessage(report, lastReportAction, true, false, null, true);
	lastMessageTextFromReport = ReportUtils.formatReportLastMessageText(properSchemaForMoneyRequestMessage);
	} else if (ReportActionUtils.isReportPreviewAction(lastReportAction)) {

I think this issue has been there and not a regression. In production, the LHN subtitle won't show the description of the money request ({payer} owes {amount}) (which is a regression from this PR). Then, the regression is fixed by adding back the description and now the QA catch this multi-line issue.

EDIT: I can't find the PR, but it might start to happen when we add description to the report preview message.

What changes do you think we should make in order to solve the problem?

Use formatReportLastMessageText for report preview action too.

App/src/libs/OptionsListUtils.ts

Lines 541 to 557 in 6463de6

	} else if (ReportActionUtils.isReportPreviewAction(lastReportAction)) {
	const iouReport = ReportUtils.getReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(lastReportAction));
	const lastIOUMoneyReportAction = allSortedReportActions[iouReport?.reportID ?? '']?.find(
	(reportAction, key) =>
	ReportActionUtils.shouldReportActionBeVisible(reportAction, key) &&
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE &&
	ReportActionUtils.isMoneyRequestAction(reportAction),
	);
	lastMessageTextFromReport = ReportUtils.getReportPreviewMessage(
	!isEmptyObject(iouReport) ? iouReport : null,
	lastIOUMoneyReportAction,
	true,
	ReportUtils.isChatReport(report),
	null,
	true,
	lastReportAction,
	);

or maybe we can use it when returning the value here so all case is applied,

App/src/libs/OptionsListUtils.ts

Line 580 in 6463de6

return lastMessageTextFromReport || (report?.lastMessageText ?? '');

[parasharrajat]

Ah, it might be a regression from #34840 which I reviewed. 🥲 . Can't verify on that PR as we are forced to update the app.

But it has already been two weeks for that PR into the production.So I think we can go with @bernhardoj's proposal.

I like the idea of universal formatting but let's make sure we don't over do it. We want to reduce the execution time for this function not increase it.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @chiragsalian is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[chiragsalian]

Proposal LGTM, are you around to create a PR for this @bernhardoj in the next hour or so?

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

Yes, I'm available. Will open the PR in a few moments.

[parasharrajat]

Thats, great. Thanks @bernhardoj

[bernhardoj]

PR is ready

cc: @parasharrajat

[chiragsalian]

Fixes have been CP-d to staging. Tested on staging and it LGTM so removing blocker label.

[chiragsalian]

Thanks for the quick turnaround time 🙂

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix report preview LHN subtitle shown as multiline #39525

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @zanyrenney you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[zanyrenney]

payment summary

@parasharrajat requires payment through NewDot Manual Requests - please request $500
@bernhardoj requires payment automatic offer (Contributor) paid $500 via upwork.

Closing.

[parasharrajat]

Payment requested as per #39437 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat