-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Chat - Size of text cursor is smaller when returning to any chat via browser back button #39303
Comments
Triggered auto assignment to @marcaaron ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #vip-vsp |
@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Seems possibly more related to markdown changes. |
@thienlnam I asked for a re-test to see. It kinda feels like this would be broken everywhere (sorry if I end up wrong on that hunch). |
Definitely possible - I'll add it to the main tracking list. But seems pretty harmless and I don't think needs to be a blocker |
Cool. If you are not passionate about it. Then I'm gonna pop the label off. |
Triggered auto assignment to @dylanexpensify ( |
p.s. confirmed with QA that this is not limited to Group Chats. |
@quinthar heads up, I added this to vip-vsb, but with LOW given it's lack of impact on usability. LMK if you disagree! |
@BartoszGrajdek @paultsimura this PR is ready for preview. |
@paultsimura @thienlnam @dylanexpensify @nkdengineer this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
PR is merged Mel! Waiting for payment day |
I believe we still need a PR to bump the |
Ah nice, thanks @paultsimura! 👍 |
@paultsimura this PR is ready for preview. |
This was deployed to production on April 22, due payment 2024-04-29 |
Payment summary:
Please apply or request! |
Hi! Can we get this issue closed? 😄 I'm trying to clean up the Live Markdown tracking issue right now :) |
We don't close issues until we get them paid out - but we can remove this from the tracking issue EDIT: I went ahead and cleaned up the main tracking issue here #36071 |
bump @nkdengineer! |
Hi @dylanexpensify, sorry for the delay, I've applied to the job https://www.upwork.com/jobs/~01e868dd4a424eb130 |
no worries, thanks!! |
offer sent! |
Hi @dylanexpensify, this issue was created on Mar 30, and according to this announcement, issues created prior to the announcement date Apr 4 will remain the original price ($500). If that's correct, could you help update the GH title and offers, thanks 🙇 |
@dylanexpensify in addition to @nkdengineer's comment above, it was quite a complex task involving an upstream fix in the Live Markdown package, so that note makes sense to me. WDYT? |
Ah, thanks for the catch, agree. Updated offer, and will pay out $500 in Upwork |
I've just applied for the job as well, thanks. |
sounds great! |
@dylanexpensify what's the payout plan on this? The payment day was a month ago, 2024-04-29 |
@paultsimura paid last week! But just sent bonus along! |
@nkdengineer waiting for you to accept offer! |
@dylanexpensify I accepted the offer. But the offer was for $250 so I guess a bonus of $250 will be sent too. Thanks 🙇 |
Correct! all done btw |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.58-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The size of text cursor will remain the same when returning to group chat via browser back button
Actual Result:
The size of text cursor is smaller when returning to group chat via browser back button
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6432037_1711744193996.20240330_042506.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: