[HOLD for payment 2024-04-15] [$500] Expense - LHN preview does not show request description for request with description

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to workspace chat that has no unsettled request.
3. Create a manual request with description.

Expected Result:

In LHN, the workspace chat preview will show the request with description (production behavior).

Actual Result:

In LHN, the workspace chat preview does not show the request description.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6429254_1711573818176.bandicam_2024-03-28_05-07-23-223.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f5e205ddbd6e0a25
• Upwork Job ID: 1773353810716704768
• Last Price Increase: 2024-03-28

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@MitchExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f5e205ddbd6e0a25

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[Gonals]

@MitchExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Adding external, as we seem to be setting the values correctly. We are just not displaying them

[nkdengineer]

I can raise the PR immediately if assigned

Proposal

Please re-state the problem that we are trying to solve in this issue.

In LHN, the workspace chat preview does not show the request description.

What is the root cause of that problem?

In here, we didn't put the comment param, so the description does not show in the request alternate text in LHN. This comes from #37773 where the comment param was removed.

What changes do you think we should make in order to solve the problem?

In here, simply put the comment param back

return Localize.translateLocal('iou.payerOwesAmount', {payer: payerName ?? '', amount: formattedAmount, comment});

What alternative solutions did you explore? (Optional)

NA

[FitseTLT]

regression from #37773 it removed comment

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN preview does not show request description for request with description

What is the root cause of that problem?

#37773 removed the comment, my best guess is that they didn't want to show it on non-reimbursible spent.

App/src/libs/ReportUtils.ts

Line 2634 in 4fbd218

return Localize.translateLocal('iou.payerOwesAmount', {payer: payerName ?? '', amount: formattedAmount});

What changes do you think we should make in order to solve the problem?

Introduce a condition to check for containsNonReimbursable and show comment only when it is false

return Localize.translateLocal('iou.payerOwesAmount', { payer: payerName ?? '', amount: formattedAmount, ...(containsNonReimbursable ? {} : { comment }) });

What alternative solutions did you explore? (Optional)

N/A

[aimane-chnaif]

@mollfpr this came from bad merge, while you're fixing merge conflict

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix LHN preview does not show request description for request with description #39208

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
• [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Pujan92] Determine if we should create a regression test for this bug.
• [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

• $500 @Pujan92 Upwork

[nkdengineer]

@MitchExpensify I think I'm also eligible for compensation here since the issue was External and my proposal was used to fix the blocker

We had many similar cases like in here.

What do you think?

[MitchExpensify]

@Gonals were the solutions like for like?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[nkdengineer]

@Gonals were the solutions #39158 (comment) for #39208?

@Gonals Bump on this, do you agree the solution used in the PR is the same as in the proposal?

Thanks 🙏

[MitchExpensify]

Offer sent to you here @Pujan92 https://www.upwork.com/jobs/~01f5e205ddbd6e0a25

Holding on buddy check on payment due to @nkdengineer

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @Pujan92 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1773353810716704768/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Pujan92]

Offer sent to you here @Pujan92 https://www.upwork.com/jobs/~01f5e205ddbd6e0a25

@MitchExpensify Thanks, Accepted!

[melvin-bot]

@Pujan92, @Gonals, @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[nkdengineer]

Holding on buddy check on payment due to @nkdengineer

@MitchExpensify Could you help reopen the issue to handle this?

Thanks

[MitchExpensify]

We can keep tabs on that while closed @nkdengineer 👍

[MitchExpensify]

Offer sent here @nkdengineer https://www.upwork.com/nx/wm/offer/102043113

Thanks for your patience, payment will be issued asap 🙇

[nkdengineer]

@MitchExpensify I accepted the offer, thanks 🙏

[MitchExpensify]

Great! Payment made and contract ended