[HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.54-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an admin of Collect workspace.

1. Open app
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Taxes.
4. Click Add rate.
5. Click Value.

Expected Result:

Able to add tax value

Actual Result:

App crashes

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418175_1710785068726.RPReplay_Final1710784552.1.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave-control

[kbecciv]

@francoisl The app crashes when adding the distance rate, do we need to create a separate GH or the same root cause?

RPReplay_Final1710786838.MP4

[allgandalf]

#38504 (comment)

@abzokhattab , looks like the same RCA is applicable here too as you mentioned over that issue

[francoisl]

I can repro on iOS, this seems to come from #37967.

The app crashes when adding the distance rate, do we need to create a separate GH or the same root cause

Not sure yet but it might be a different cause, the PR I linked to is specific to tax rates. Maybe it's safer to open a separate issue for now.

[luacmartins]

This was introduced #37967. This is NAB since this feature is only available on Collect policies in NewDot and users don't have access to that yet. I think we can address that as a follow up to the other tax PRs. cc @kosmydel @filip-solecki

[abzokhattab]

i get the same error message as this one: #38504 (comment)

so I believe it has the same root cause:

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

I am making a revert of that PR, we can just give it another go later knowing these issues

[luacmartins]

This has been fixed by the revert. Gonna close.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "[NoQA][Audit][Implementation] - Remove Intl Polyfills which are supported by Hermes on native platforms" #38508

If no regressions arise, payment will be issued on 2024-03-26. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "[NoQA][Audit][Implementation] - Remove Intl Polyfills which are supported by Hermes on native platforms" #38508

If no regressions arise, payment will be issued on 2024-03-29. 🎊

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Audit][Implementation] - Remove Intl Polyfills which are supported by Hermes by separating iOS and android implementation #38565

If no regressions arise, payment will be issued on 2024-04-05. 🎊