[HOLD for payment 2024-03-26] [$250] [Wave Collect] [More Features] WS features - App returns to the same WS settings page after toggling on a feature

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.51-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #37441

Action Performed:

Precondition:

• User is an owner of Collect workspace
• The Collect workspace has enabled categories

1. Go to staging.new.expensify.com
2. Go to workspace settings > Collect workspace
3. Go to More features
4. Toggle on any feature (toggle off first if there is disabled feature)
5. Return to previous page via device back navigation

Expected Result:

App will not return to the same page. App will return to workspace list

Actual Result:

App returns to the same workspace settings page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6411552_1710276925761.Screen_Recording_20240313_044608_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012238c91ec26d9e5d
• Upwork Job ID: 1768644608825819136
• Last Price Increase: 2024-03-15
• Automatic offers:
• ishpaul777 | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave-control
CC @jason

[lanitochka17]

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

WS features - App returns to the same WS settings page after toggling on a feature

What is the root cause of that problem?

We use CONST.NAVIGATION.TYPE.FORCED_UP as type when navigating to WORKSPACE_INITIAL route and this replaces current route with new route instead of adding new one to the stack.

App/src/libs/actions/Policy.ts

Lines 2920 to 2930 in 92bbd8b

	function navigateWhenEnableFeature(policyID: string, featureRoute: Route) {
	const isNarrowLayout = getIsNarrowLayout();
	if (isNarrowLayout) {
	Navigation.navigate(ROUTES.WORKSPACE_INITIAL.getRoute(policyID), CONST.NAVIGATION.TYPE.FORCED_UP);
	return;
	}
	Navigation.navigate(featureRoute);
	}

What changes do you think we should make in order to solve the problem?

Remove the second parameter CONST.NAVIGATION.TYPE.FORCED_UP or use Navigation.goBack(ROUTES.WORKSPACE_INITIAL.getRoute(policyID)); instead.

Optional: use Navigation.goBack() without fallback route.

Edit: Removing the second parameter CONST.NAVIGATION.TYPE.FORCED_UP won't work as expected but Navigation.goBack() does.

Result

[marcaaron]

Looks connected to #37441 cc @mountiny @rezkiy37 @luacmartins

The above proposal looks like it will work. But maybe we are already looking into this?

[luacmartins]

This is not a blocker since the feature is still WIP and very few people have access to Collect workspaces on NewDot. cc @rezkiy37 can you work on a fix for this one as well?

[mountiny]

Head up, just merged the ideal nav v2 so it might influence the solution a bit regarding routes

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work on this issue.

[rezkiy37]

I've tested the bug. The bug is not replicable after the "Ideal Nav V2" merging. I tested on a real Android Device and macOS Chrome. Can you retest also, please?

cc @lanitochka17

Android.Chorme.mp4

[rezkiy37]

However, I agree that the goBack looks better and natural. I would create a PR to use Navigation.goBack(ROUTES.WORKSPACE_INITIAL.getRoute(policyID));. When we deep-link to the "More features" page for the 1st time, it calls navigate with CONST.NAVIGATION.TYPE.FORCED_UP, but after the navigation history has been initiated and goBack works smoothly.

WDYT, @mountiny?

Nav.mp4

[rezkiy37]

One more thing I see is that the app uses a legacy route for the "More features" page.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[zanyrenney]

Hi @abekkala Just a note to say, I am OOO now until April 2nd, reassigning BZ team member to help while I am OOO.

[abekkala]

@zanyrenney I'm going to be ooo as well. It's best practice to check the ooo calendar and reapply if needed. and provide a summary comment

[abekkala]

PAYMENT SUMMARY FOR MAR 26

• @rezkiy37 does not require payment (Contractor)
• @ishpaul777 $250 automatic offer (Contributor)

[melvin-bot]

Current assignee @zanyrenney is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[abekkala]

@bfitzexpensify - @zanyrenney was the original assignment. She is going ooo.

I've provided the Payment summary above and reapplied the label. I verified that you were not currently on the ooo calendar for Mar 26

Thanks!

[luacmartins]

Just pending payment

[bfitzexpensify]

All done!

[ishpaul777]

Hii @bfitzexpensify I think payment is still pending for this one i haven't accepted the offer it links me to a invalid link and also i couldnt find this issue in my transaction history, could you please check

[bfitzexpensify]

Hey @ishpaul777 - looks like payment was issued March 27th for Expensify GH #38185 - Contributor - [$500] [Wave Collect] [More Features] WS features - App returns to the same WS settings page after toggling on a feature

Can you check that on your end?

[ishpaul777]

oh i see i found it, it got lost in the history, sorry and Thank you!