[HOLD for payment 2024-03-20] Tag - Newly added tags aren't displayed under the "Tags" section in workspace settings

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.48-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

Precondition:
User is an admin of Collect workspace with no previously added tags (you should add new tags before steps reproduction )

1. Navigate to staging.new.expensify.com
2. Go to Workspace settings > Collect workspace
3. Select the "Tags" tab
4. Add some tags via classic app
5. Refresh the page to see the newly added tags

Expected Result:

Newly added tags should be displayed under the "Tags" section in workspace settings.

Actual Result:

Newly added tags aren't displayed under the "Tags" section in workspace settings.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6405013_1709793110758.tags.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@MonilBhavsar I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

[MonilBhavsar]

@luacmartins @waterim @Abdallah-Ahmed-moh looks like it is coming from this PR #37621
Given that this is WIP under simplified collect, I think this is not a not a blocker. Let me know what do you think

[waterim]

That means that policyTags which are coming from the backend are empty for some reason, I will check

[MonilBhavsar]

Yes, I confirmed Onyx updates are not being delivered. I am aware of work going on to deliver Policy onyx updates to send update to everyone. I think this is not a blocker. Would like to hear from #33047 #simplified-collect team though

[luacmartins]

This is not a blocker, but @waterim we need to call OpenPolicyTagsPage API command when we load the page to make sure we load those, similar to how we do here

[MonilBhavsar]

Assigning @waterim to the issue as per above mentioned comment

[waterim]

@MonilBhavsar This one will be added here

[luacmartins]

Nice! Added this issue to the list of fixed issues in that PR.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Create WorkspaceTagsSettingsPage #37755

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

• @waterim does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins / @MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins / @MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins / @MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@waterim] Determine if we should create a regression test for this bug.
• [@waterim] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[greg-schroeder]

Apologies, I was OOO last week. Taking a look at this now!

[greg-schroeder]

Closing per #37873 (comment)