[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Workspace - "Free" user is able to see "Admin Role" when WS is made as "Default"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.47-2
Reproducible in staging?: y
Reproducible in production?: new feature
Issue found when executing PR: #37199
Issue reported by: Applause - Internal Team

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Go to WS settings > Tap on a FREE workspace that is set to "Default" in OD site.
4. Go to members > Select a couple of member and access the drop down menu in the top right

Expected Result:

User does NOT expect to see "Make admin" option, as per the PR, seems this should be limited to "Collect Workspace"

Actual Result:

"Make admin" option is shown for a FREE Workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6403169_1709663276853.Free_WS_shows_admin_option_.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[nexarvo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Free" user is able to see "Admin Role" when WS is made as "Default"

What is the root cause of that problem?

There is not condition to hide "make admin" button if the workspace is free.

What changes do you think we should make in order to solve the problem?

We need to add a condition to check if the workspace plan is free then we will not show the "make admin" button

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 419 to 426 in 9c2f146

	if (selectedEmployees.find((employee) => policyMembers?.[employee]?.role === CONST.POLICY.ROLE.USER)) {
	options.push({
	text: translate('workspace.people.makeAdmin'),
	value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.MAKE_ADMIN,
	icon: Expensicons.MakeAdmin,
	onSelected: () => changeUserRole(CONST.POLICY.ROLE.ADMIN),
	});
	}

The if condition will become:

+ if (selectedEmployees.find((employee) => policyMembers?.[employee]?.role === CONST.POLICY.ROLE.USER) && policy?.type !== CONST.POLICY.TYPE.FREE)
- if (selectedEmployees.find((employee) => policyMembers?.[employee]?.role === CONST.POLICY.ROLE.USER))

What alternative solutions did you explore? (Optional)

Result

Before	After

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Free" user is able to see "Admin Role" when WS is made as "Default"

What is the root cause of that problem?

We push the admin option for any type of workspace

App/src/pages/workspace/WorkspaceMembersPage.tsx

Lines 419 to 426 in 9c2f146

	if (selectedEmployees.find((employee) => policyMembers?.[employee]?.role === CONST.POLICY.ROLE.USER)) {
	options.push({
	text: translate('workspace.people.makeAdmin'),
	value: CONST.POLICY.MEMBERS_BULK_ACTION_TYPES.MAKE_ADMIN,
	icon: Expensicons.MakeAdmin,
	onSelected: () => changeUserRole(CONST.POLICY.ROLE.ADMIN),
	});
	}

What changes do you think we should make in order to solve the problem?

Limit the admin option to only collect workspace as per the bug description.

We can update the if condition as follows:

if (policy?.type === CONST.POLICY.TYPE.TEAM && selectedEmployees.find((employee) => policyMembers?.[employee]?.role === CONST.POLICY.ROLE.USER)) { 

What alternative solutions did you explore? (Optional)

If we want to apply this for both paid policy types i.e. TEAM as well as CORPORATE, then we can use isPaidGroupPolicy as well from PolicyUtils.

[Tony-MK]

Hi @usman-ghani564 and @GandalfGwaihir, I believe both of your proposals are the same but, have considered using the PolicyUtils.isPaidGroupPolicy function.

[allgandalf]

User does NOT expect to see "Make admin" option, as per the PR, seems this should be limited to "Collect Workspace"

Thanks for bringing this up @Tony-MK , the bug description says that this should be limited to collect workspace but your suggestions are also solid if we want it for CORPORATE policy type as well, I will update this in my alternative solution :)

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[nexarvo]

@luacmartins PR for this issue is ready for review #37808

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: allow make admin in paid workspace only #37808

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @usman-ghani564 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@usman-ghani564] Determine if we should create a regression test for this bug.
• [@usman-ghani564] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: allow make admin in paid workspace only #37808

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

• @usman-ghani564 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins / @stitesExpensify] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins / @stitesExpensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins / @stitesExpensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@usman-ghani564] Determine if we should create a regression test for this bug.
• [@usman-ghani564] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[stephanieelliott]

I'm confused -- was there no C+ on this issue? it looks like multiple people reviewed the PR however none are assigned here. I'll assume the C+ role was covered internally since this was a deploy blocker but LMK if there is a C+ that needs to be paid here.

Summarizing payment on this issue:

• Contributor: @usman-ghani564 $500 PAID via Upwork
• Contributor+: (N/A, internal @luacmartins )

Upwork job is here: https://www.upwork.com/jobs/~01e675ca37df68cdf5

[stephanieelliott]

Also a reminder to complete the BZ checklist @luacmartins @usman-ghani564

[nexarvo]

@stephanieelliott Please find my Upwork profile here: https://www.upwork.com/freelancers/~01b5c4ee99eace8e60

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @usman-ghani564 paid $(AMOUNT) via Upwork https://www.upwork.com/jobs/~01e675ca37df68cdf5

BugZero Checklist (@stephanieelliott)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[nexarvo]

• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Sign into a valid account
2. Go to WS settings
3. Tap on a FREE workspace that is set to "Default" in OD site.
4. Go to members
5. Select a couple of member and access the drop down menu in the top right
6. Validate you don't see "make admin" and "make member" buttons in the drop down menu.

Do we agree 👍 or 👎

[luacmartins]

We'll add regression tests when this feature is fully implemented. No need to add those now.

[melvin-bot]

@luacmartins, @stephanieelliott, @stitesExpensify, @usman-ghani564 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stephanieelliott]

Sent the offer to you in Upwork @usman-ghani564!

[nexarvo]

Accepted @stephanieelliott

[stephanieelliott]

Thanks! All paid per the payment summary here.

[ishpaul777]

Hey @stephanieelliott @luacmartins I reviewed the PR here #37808 Can we reopen for payment please 🙇‍♂️

[stephanieelliott]

Oop, thanks @ishpaul777, i was confused about who reviewed this one. Sent the offer to you in Upwork. please accept when you get a chance!

https://www.upwork.com/jobs/~01cae713fcc9593bd0

[ishpaul777]

Thanks! I have accepted the offer

[stephanieelliott]

All paid! New payment summary, updated from #37779 (comment):

Contributor: @usman-ghani564 $500 PAID via Upwork (Upwork job https://www.upwork.com/jobs/~01e675ca37df68cdf5)
Contributor+: @ishpaul777 $500 PAID via Upwork (Upwork job https://www.upwork.com/jobs/~01cae713fcc9593bd0

[ishpaul777]

Thank you!