[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Split scan - Split button in split menu is gray instead of green

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.47-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat > + > Split bill.
3. Go to Scan.
4. Create a scan split request.
5. Click on the split preview.

Expected Result:

The split button will be green.

Actual Result:

The split button is gray.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6402237_1709602730996.bandicam_2024-03-05_06-23-19-887__1_.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think that this bug might be related to #vip-split-p2p-chat-groups
cc @arielgreen

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The split button is gray.

What is the root cause of that problem?

From this PR #37199, the default value success of success is false

App/src/components/ButtonWithDropdownMenu/index.tsx

Line 17 in a79c119

success = false,

and we don't pass success as true into ButtonWithDropdownMenu so the split button displays as the default button

App/src/components/MoneyRequestConfirmationList.js

Line 552 in a79c119

<ButtonWithDropdownMenu

What changes do you think we should make in order to solve the problem?

Pass success as true into ButtonWithDropdownMenu

App/src/components/MoneyRequestConfirmationList.js

Line 552 in a79c119

<ButtonWithDropdownMenu

What alternative solutions did you explore? (Optional)

Change the default value of success prop of ButtonWithDropdownMenu to true

[aimane-chnaif]

cc: @burczu

[MonilBhavsar]

Since it is a regression, it should be basically fixed by an author

[burczu]

@MonilBhavsar Yes - this is regression. Can you please assign it to me?

[MonilBhavsar]

@burczu @aimane-chnaif assigned you both to this issue

[burczu]

@aimane-chnaif The PR is read for review: #37719

[MonilBhavsar]

This is fixed on staging!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] #37711 drop down button uses success design on confirmation list #37719

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[aimane-chnaif]

We can close this

[MonilBhavsar]

Yes, thanks all!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] #37711 drop down button uses success design on confirmation list #37719

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

• @burczu does not require payment (Contractor)
• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: