[$250] Remove Add receipt from the three dot overflow menu

[JmillsExpensify]

Problem

We've recently added a receipt empty state in conjunction with the on-going violations project, though we also have an existing Add receipt option in the three dot overflow menu. Example below.

Accordingly, we effectively have two options to do the same thing, within the same screen. That's confusing and unnecessary.

Solution

Let's remove the Add receipt option in the three dot overflow menu, such that the receipt empty state is the only/main flow for adding receipts.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01462cd7dc3ef5fb51
• Upwork Job ID: 1760460411785555968
• Last Price Increase: 2024-02-22
• Automatic offers:
• s77rt | Reviewer | 0
• Krishna2323 | Contributor | 0

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01462cd7dc3ef5fb51

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Upwork job price has been updated to $250

[JmillsExpensify]

Super straightforward issue so updating the price accordingly.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Add receipt from the three dot overflow menu

What is the root cause of that problem?

New Feature

What changes do you think we should make in order to solve the problem?

We will remove the option form MoneyRequestHeader here

We will also remove the beta violation check for receipt empty state here:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 275 to 276 in 8783eb4

	{!hasReceipt && canEditReceipt && canUseViolations && (
	<ReceiptEmptyState

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Add receipt from the three dot overflow menu

What is the root cause of that problem?

new feature

What changes do you think we should make in order to solve the problem?

Need to remove the code below:

App/src/components/MoneyRequestHeader.tsx

Lines 151 to 167 in 936ae8f

	if (canModifyRequest) {
	if (!TransactionUtils.hasReceipt(transaction)) {
	threeDotsMenuItems.push({
	icon: Expensicons.Receipt,
	text: translate('receipt.addReceipt'),
	onSelected: () =>
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
	CONST.IOU.ACTION.EDIT,
	CONST.IOU.TYPE.REQUEST,
	transaction?.transactionID ?? '',
	report.reportID,
	Navigation.getActiveRouteWithoutParams(),
	),
	),
	});
	}

Result

[Krishna2323]

Hey @neonbhai, you updated your proposal after mine, initially you were just pointing out this issue as reference which I could have also done before your proposal without checking the codebase and getting the correct reference. I hope that makes sense.

cc: @s77rt

[nexarvo]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Add receipt from the three dot overflow menu

What is the root cause of that problem?

New Request

What changes do you think we should make in order to solve the problem?

We are pushing Add receipt to three dot menu. We need to remove code where it is being pushed to array, like this:

App/src/components/MoneyRequestHeader.tsx

Lines 152 to 167 in 3e77445

	if (!TransactionUtils.hasReceipt(transaction)) {
	threeDotsMenuItems.push({
	icon: Expensicons.Receipt,
	text: translate('receipt.addReceipt'),
	onSelected: () =>
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
	CONST.IOU.ACTION.EDIT,
	CONST.IOU.TYPE.REQUEST,
	transaction?.transactionID ?? '',
	report.reportID,
	Navigation.getActiveRouteWithoutParams(),
	),
	),
	});
	}

[melvin-bot]

📣 @usman-ghani564! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[nexarvo]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01b5c4ee99eace8e60

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[askavyblr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove Add receipt from the three dot overflow menu

What is the root cause of that problem?

New Feature

What changes do you think we should make in order to solve the problem?

Need to remove Below Lines

App/src/components/MoneyRequestHeader.tsx

Lines 152 to 166 in 42f1c68

	if (!TransactionUtils.hasReceipt(transaction)) {
	threeDotsMenuItems.push({
	icon: Expensicons.Receipt,
	text: translate('receipt.addReceipt'),
	onSelected: () =>
	Navigation.navigate(
	ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
	CONST.IOU.ACTION.EDIT,
	CONST.IOU.TYPE.REQUEST,
	transaction?.transactionID ?? '',
	report.reportID,
	Navigation.getActiveRouteWithoutParams(),
	),
	),
	});

What alternative solutions did you explore? (Optional)

[s77rt]

@JmillsExpensify Currently the receipt empty state is only available for users with violations beta enabled. Is this still the case? Can we remove that restriction? cc @cead22 #30663

With beta	Without beta

[handipriyono]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01d78cbc4edbcfa8e7

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[handipriyono]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Remove Add receipt option in the three dot overflow menu

What is the root cause of that problem?

• eliminate `Add receipt' from three dot menu ( currently still showing)

What changes do you think we should make in order to solve the problem?

• remove lines of code when "add receipt" menu being pushed to threeDotsMenuItems array. In this specific line.
  

  App/src/components/MoneyRequestHeader.tsx

  Lines 152 to 167 in 143d88b

  	if (!TransactionUtils.hasReceipt(transaction)) {
  	threeDotsMenuItems.push({
  	icon: Expensicons.Receipt,
  	text: translate('receipt.addReceipt'),
  	onSelected: () =>
  	Navigation.navigate(
  	ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(
  	CONST.IOU.ACTION.EDIT,
  	CONST.IOU.TYPE.REQUEST,
  	transaction?.transactionID ?? '',
  	report.reportID,
  	Navigation.getActiveRouteWithoutParams(),
  	),
  	),
  	});
  	}

What alternative solutions did you explore? (Optional)

[JmillsExpensify]

@JmillsExpensify Currently the receipt empty state is only available for users with violations beta enabled. Is this still the case? Can we remove that restriction? cc @cead22 #30663

With beta Without beta

Yes, violations are still being implemented and under a beta. In fact, this is what has created the duplicate flows to do the same thing. So we want to remove Add receipt from the overflow menu as we're cleaning up this overall flow.

P.S. I also reached out to Carlos via DM to confirm he's aligned.

[cead22]

That sounds good to me, and we can remove the beta check for violations that we currently have for display the receipt empty state

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 275 to 276 in 8783eb4

	{!hasReceipt && canEditReceipt && canUseViolations && (
	<ReceiptEmptyState

[neonbhai]

Proposal

Updated

[s77rt]

@neonbhai Thanks for the proposal. Based on the edit timeline, @Krishna2323 was the first in proposing the appropriate changes.

[s77rt]

@Krishna2323 Thanks for the proposal. The suggested changes looks good to me.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

@usman-ghani564 Thanks for the proposal. Unfortunately your proposal is a dupe

[s77rt]

@askavyblr Thanks for the proposal. Your proposal is also a dupe.

[s77rt]

@handipriyono Thanks for the proposal. This one is also a dupe.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@s77rt PR ready for review.

[Krishna2323]

@JmillsExpensify friendly bump for payments here :)

[Krishna2323]

@JmillsExpensify bump for payments process 🙇🏻

[melvin-bot]

@JmillsExpensify @s77rt @Krishna2323 @hayata-suenaga this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[hayata-suenaga]

waiting for payment

[Krishna2323]

waiting for payment process by @JmillsExpensify

[JmillsExpensify]

Not sure why the automation failed, though please reach out to me via DM for these cases. I'm on hundreds of issues so it's hard to keep track.

[JmillsExpensify]

Payment summary:

• Contributor: @Krishna2323 $250
• Contributor+P @s77rt $250

All contracts paid. Given that we are removing functionality, I don't think we need to create a regression test for this case.