[HOLD for payment 2024-03-20] HIGH: [$1000] MacOS App does not update via 'Check for Updates' when an update is available

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.40-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707839105781559

Action Performed:

Prereq: Must be running an out-of-date version of the MacOS app + have an update to the MacOS app available

1. Open MacOS app
2. Ignore any 'update available' pop up
3. Select New Expensify > Check for Update in the menu bar
4. You'll see a notification titled "Update Available"

Expected Result:

If an update is available, there should be an option to update the app.

Actual Result:

There isn't a way to update the app in the message. The button just says 'Sounds Good' and clicking it only closes the

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2024-02-13_14-28-13.mp4

update.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019cdfd41c70cb0eeb
• Upwork Job ID: 1757798834716602368
• Last Price Increase: 2024-03-08

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019cdfd41c70cb0eeb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kameshwarnayak]

Looks like an expected behaviour. The message clearly says "The new version will be available shortly. We'll notify you when we're ready to update." It is not supposed to do anything I suppose.

[garrettmknight]

@johncschuster just reassigning in case this needs help while I'm OOO this week - will be back 2/21 to pick it back up

[mallenexpensify]

@johncschuster and @eVoloshchak , are you able to reproduce this on Desktop? It's still happening for me, trying to suss out how common the bug is (and what the specific work-around is to get the app to update).

Also checking in the Slack thread to see if others are experiencing and repro steps if so.

[dangrous]

I think this is happening to me on Desktop staging - v 1.4.40-0

[eVoloshchak]

I'm able to reproduce this on Desktop
I agree with @kameshwarnayak's comment, the modal itself should just close and do nothing

The message clearly says "The new version will be available shortly. We'll notify you when we're ready to update." It is not supposed to do anything I suppose.
(what is the purpose of this modal?)

However, I think the real problem is the app not updating. My Desktop app is stuck on 1.4.8-1, pressing 'Update New Expensify' does nothing

[melvin-bot]

@garrettmknight, @johncschuster, @eVoloshchak Eep! 4 days overdue now. Issues have feelings too...

[dangrous]

yeah thanks for the clarification @eVoloshchak - I think usually there is some delay between clicking that and the update itself, so the update is the issue not the button.

I am struggling to figure out a way to fix stuck versions, though. Because even if we fix this, how do we update the versions that won't update in order for them to update?

[mallenexpensify]

The message clearly says "The new version will be available shortly. We'll notify you when we're ready to update." It is not supposed to do anything I suppose.
(what is the purpose of this modal?)

@kameshwarnayak , @eVoloshchak , For the past couple years, the flow was a version of

• Click Check for Updates
• Click button to Update
• Pop surfaces asking if you'd like to update
• App closes, updates, reopens.

It seemed to make more sense that way than the way it is now where the version can get stuck and not updated for a while. Albeit... this is only for Desktop and I think most users are on web, so it's likely not the highest priority.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[garrettmknight]

Back and picking this one up - @mallenexpensify I think this is might be working as expected. When an update is available, the menu item reads something differently than 'Check for updates'. I think it's 'Update New Expensify' or something like that. When you click it, it updates.

To make sure I'm repro'ing correctly, what's the initial scenario we need to test?

• Must have updated NewDot Desktop version available
• Must have ignored the initial pop-up? Or is this before the pop-up happens?

[garrettmknight]

Setting to Needs reproduction until I can figure out how to test.

[puneetlath]

I'm experiencing this problem too.

You can click "check for updates" and then "sounds good" as much as I want. The ability to actually update the app never arrives, even though I am behind.

[garrettmknight]

I just tested and 'Check for updates' didn't notify me when the download was complete. I waited for 30 mins before closing/reopening the app to confirm that the udpate completed. @s77rt should that change have gone into effect immediately or do I need to wait for another release to test again?

[s77rt]

@garrettmknight On which version you tested? You need at least version 1.4.54-0 to test on

[garrettmknight]

I'm on 1.4.54-1 now - will wait for the next update to test in that case.

[lakchote]

@garrettmknight On which version you tested? You need at least version 1.4.54-0 to test on

@s77rt It should have worked for Garrett, no? Since he was on version 1.4.54-1.

It has now been deployed to production on 1.4.54-4 @garrettmknight, could you test again please?

[garrettmknight]

I wasn't on 1.4.54-1 when I tested, that's what it updated to from the older version. Annnnnddd my computer restarted so the new version installed automatically when I reopened. WIll hold to test on the next release - unless you have an earlier version and can test now @lakchote ?

[puneetlath]

I was just able to update my Desktop app from 1.4.54-1 to 1.4.55-0.

[lakchote]

I wasn't on 1.4.54-1 when I tested, that's what it updated to from the older version. Annnnnddd my computer restarted so the new version installed automatically when I reopened. WIll hold to test on the next release - unless you have an earlier version and can test now @lakchote ?

Understood, thanks for the precision Garrett. Unfortunately, I already have the latest version.

But it looks like it works since @puneetlath just test it successfully!

[garrettmknight]

Nice, thanks @puneetlath. We can finish this one up then. Since this got fixed without the work here, but we had a pretty active PR going I'm going to partially pay out at 50%.

[garrettmknight]

@s77rt offer out to you.

[garrettmknight]

Summary of payment:

• Contributor: @s77rt $500 to be paid via Upwork
• Reviewer: @eVoloshchak $500

Upwork link

[s77rt]

@puneetlath Just to confirm, you saw a popup or a notification informing you that the update is downloaded right? Because the update was never broken, it was just silent

[s77rt]

@garrettmknight Accepted

[puneetlath]

Hmm, I don't remember if I saw the popup 😅. I can check again next time. When I do "check for updates" now I get this, which I wasn't getting before, so that seems good.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @s77rt $500 to be paid via Upwork
• Reviewer: @eVoloshchak $500

BugZero Checklist (@garrettmknight)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1757798834716602368/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[garrettmknight]

Will complete the payment summary tomorrow when I test to double-confirm things are working.

[garrettmknight]

Noting that I just clicked check for updates and got the update available message + now I can't click check for updates:

[garrettmknight]

And just got the pop-up:

[garrettmknight]

@eVoloshchak please request payment when you're ready.

[JmillsExpensify]

$500 approved for @eVoloshchak based on summary.