[HOLD for payment 2024-02-26] [$500] Expense - "Recent" and "All" appear in report field selection list when there is no result

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: .1.4-36.1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of Collect workspace
• The Collect workspace has dropdown field set up in "Report and Invoice Fields" on Old Dot

1. Go to workspace chat
2. Create a request
3. Go to expense report
4. Click on the report field with the selection list set up from Old Dot
5. Search for an invalid term
   Note that "Recent" and "All" appear when there are no relevant results

Expected Result:

In Step 4, when there is no recent item, "Recent" will not appear in the list
In Step 5, when there is no search result, "Recent" and "All" will not appear in the list

Actual Result:

In Step 4, when there is no recent item, "Recent" appears in the list
In Step 5, when there is no search result, "Recent" and "All" also appear in the list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6367962_1707149161081.bandicam_2024-02-05_21-13-05-298__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d9bb73088604e957
• Upwork Job ID: 1754584397767528448
• Last Price Increase: 2024-02-05
• Automatic offers:
• Amarparab2024 | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave6
CC @greg-schroeder

[aeioual]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Recent" and "All" appear in report field selection list when there is no result

What is the root cause of that problem?

We have a condition to always show the recents regardless of the list being empty

App/src/pages/EditReportFieldDropdownPage.tsx

Line 54 in 34330e2

shouldShow: true,

What changes do you think we should make in order to solve the problem?

Update the function to only show the recents if the list is not empty

shouldShow: !_.isEmpty(recentlyUsedOptions)

We already do that at other places

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 166 in 34330e2

shouldShow: !_.isEmpty(newChatOptions.recentReports),

Same approach will be followed for All list

What alternative solutions did you explore? (Optional)

N/A

[mountiny]

Not a blocker, this is behind beta cc @thienlnam @allroundexperts

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d9bb73088604e957

[melvin-bot]

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Recent and All text is visible when there is no data for the respective sections.

What is the root cause of that problem?

we are using the EditReportFieldDropdownPage component to display the edit report field page here,

App/src/pages/EditReportFieldPage.tsx

Lines 104 to 116 in 92e46ff

	if (reportField.type === 'dropdown') {
	return (
	<EditReportFieldDropdownPage
	policyID={report.policyID ?? ''}
	fieldID={reportField.fieldID}
	fieldName={Str.UCFirst(reportField.name)}
	fieldValue={fieldValue}
	fieldOptions={reportField.values}
	onSubmit={handleReportFieldChange}
	/>
	);
	}
	}

beneat the EditReportFieldPage we are showing the Recents and All section here,

App/src/pages/EditReportFieldDropdownPage.tsx

Lines 51 to 72 in 92e46ff

	return [
	{
	title: translate('common.recents'),
	shouldShow: true,
	data: filteredRecentOptions.map((option) => ({
	text: option,
	keyForList: option,
	searchText: option,
	tooltipText: option,
	})),
	},
	{
	title: translate('common.all'),
	shouldShow: true,
	data: filteredRestOfOptions.map((option) => ({
	text: option,
	keyForList: option,
	searchText: option,
	tooltipText: option,
	})),
	},
	];

above we can see the shouldShow is hard coded true, show it doesnt matter the length of the all or recent data we always show the All and Recent text, thats the cause of the issue

What changes do you think we should make in order to solve the problem?

We have to add the check here for the respective option

1. For the Recents we have to check of the filteredRecentOptions's length greater than 0 then shoudShow will be true or false
   

   App/src/pages/EditReportFieldDropdownPage.tsx

   Lines 53 to 54 in 92e46ff

   	title: translate('common.recents'),
   	shouldShow: true,

shouldShow: filteredRecentOptions.length > 0,

2. For the All we have to check of the filteredRestOfOptions's length greater than 0 then shoudShow will be true or false

App/src/pages/EditReportFieldDropdownPage.tsx

Lines 63 to 64 in 92e46ff

	title: translate('common.all'),
	shouldShow: true,

shouldShow: filteredRestOfOptions.length > 0,

Result

recent-and-all-text-hide-on-empty.mov

What alternative solutions did you explore? (Optional)

none

[aeioual]

Just making my proposal noticeable as i posted it before the help wanted tag 😅😁

[NikkiWines]

@allroundexperts can you give the proposals here a review? 🙇

[allroundexperts]

@Amarparab2024's proposal looks good to me. @jayeshmangwani your proposal seems to be a duplicate.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @NikkiWines is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[jayeshmangwani]

@allroundexperts Sorry, can you which part do you think is duplicate ?
selected proposal does not have the include the condition for the all contacts part.

[jayeshmangwani]

Hi @Amarparab2024 , Yes I know the rule, but can you check your root cause where you have include only the part of the recent option, you didn't mentioned the "All" contacts part, and it should be included, it is in the description.

We have a condition to always show the recents regardless of the list being empty

[allroundexperts]

I think this was a fairly simple to fix bug and the first proposal is conveying the RCA correctly as well. Elaborating it further doesn't seem to make your proposal any better. I would still go with the first proposal, but lets wait on the assigned internal engineer 😄

[aeioual]

Thanks you so much @allroundexperts :)

[NikkiWines]

Yeah, agreed with @allroundexperts here. For such a simple bug, @Amarparab2024's proposal is totally sufficient. @jayeshmangwani, your proposal is also good, but in this scenario, there's not significant enough of a difference between the proposals to warrant choosing the later one.

[melvin-bot]

📣 @Amarparab2024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[aeioual]

PR #36304 ready for review :) @allroundexperts

[aeioual]

The PR was deployed to staging 5 days back, did the automation fail, or do we need to wait until it is deployed to production ? @slafortune @NikkiWines 🤔

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: "Recent" and "All" appear in report field selection list when there is no result #36304

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @Amarparab2024 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

Waiting on @allroundexperts to complete checklist -

@allroundexperts requires payment through NewDot Manual Requests - $500
@Amarparab2024 Pay $500 via Upworks - PAID

[allroundexperts]

Checklist

1. feat: Add report field picker components #34157
2. https://github.com/Expensify/App/pull/34157/files#r1505391575
3. N/A
4. This is really minor so a regression test might not be needed. However, if we decide on adding it, then the steps in the OP look good enough.

[slafortune]

Thanks @allroundexperts !

@allroundexperts requires payment through NewDot Manual Requests - $500
@Amarparab2024 Pay $500 via Upworks - PAID

[JmillsExpensify]

$500 approved for @allroundexperts based on summary above.