[HOLD for payment 2024-02-07] [HOLD for payment 2024-02-07] [$500] Personal details - First item in the list is not highlighted when searching for country

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.33-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to Settings > Profile > Personal details.
2. Go to Address.
3. Go to Country.
4. Search for any country.

Expected Result:

The first item in the list is highlighted.

Actual Result:

The first item in the list is not highlighted.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6360414_1706586721663.bandicam_2024-01-30_06-20-47-691.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fc6fb38951fd8aeb
• Upwork Job ID: 1752281579575689216
• Last Price Increase: 2024-01-30

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fc6fb38951fd8aeb

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[Pujan92]

Seems a regression from #34485

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Personal details - First item in the list is not highlighted when searching for country

What is the root cause of that problem?

This the regression from issue - 34485.

What changes do you think we should make in order to solve the problem?

If we change it from !canSelectMultiple to canSelectMultiple it will solve the issue.

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 357 to 359 in aaa658f

	if (!canSelectMultiple) {
	return;
	}

screen-recording-2024-01-30-at-44728-pm_cGDNzrkl.mp4

What alternative solutions did you explore? (Optional)

N/A

[lakchote]

Seems a regression from #34485

#34485 is indeed the culprit 👍

[Ollyws]

@AnshuAgarwal24 Won't that re-create the issue fixed in #34485 ?

I think this one should probably be dealt with by the PR authors given it's in the regression period.
@neonbhai @eVoloshchak

[lakchote]

@AnshuAgarwal24 Won't that re-create the issue fixed in #34485 ?

I think this one should probably be dealt with by the PR authors given it's in the regression period. @neonbhai @eVoloshchak

That's my concern too.
I've tagged the PR authors on Slack and I'll revert the changes in the meantime.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MitchExpensify]

I think this one should probably be dealt with by the PR authors given it's in the regression period.
@neonbhai @eVoloshchak

Agree

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.33-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert #34485 #35386

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

No payment due here as this is a regression

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert #34485 #35386

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Reminder set to pay!

[Ollyws]

No payment necessary for this one.

[MitchExpensify]

Ah, nice. Thanks for clarifying

[MitchExpensify]

What about the BZ steps @Ollyws ?

[Ollyws]

It was just a revert so I don't think they're necessary.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @Ollyws paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1752281579575689216/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct