[$500] [MEDIUM] mweb - In employee WS, opening an expense detail page and tapping back, page gets scrolled.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.25-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap on employee Workspace chat with lot of expenses
3. Tap on any IOU to open detail page
4. Tap back button and note page gets scrolled
5. Tap back button again and note page gets scrolled

Expected Result:

When in employee WS, opening an expense detail page and tapping back, page must not get scrolled.

Actual Result:

When in employee WS, opening an expense detail page and tapping back, page gets scrolled.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6344133_1705400980897.az_recorder_20240116_042406.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01122bfdd943c30cad
• Upwork Job ID: 1747243693339979776
• Last Price Increase: 2024-05-07

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01122bfdd943c30cad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[Ykumar1415]

I tried to produce this issue and it it showing the same.

[melvin-bot]

📣 @Ykumar1415! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[situchan]

No proposals yet

[CortneyOfstad]

Not overdue

[CortneyOfstad]

Not overdue...

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[situchan]

Still looking for proposals

[situchan]

Same

[melvin-bot]

@CortneyOfstad @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

Not overdue – still waiting on proposals.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

@Piotrfj — I've been reviewing this and can you provide some additional context as to why you think an Onyx update is needed? Reviewing this with the team, we're having trouble making that connection. Any additional insight you can provide would be great 👍

[koko57]

@CortneyOfstad Piotr meant that while we go back to the previous chat Onyx is updated and this update causes scrolling of the screen. When we go back while online GetNewerActions request is sent and the report data in Onyx is updated.

I've checked it on the WEB and it also gets scrolled - let me know if I reproduced it correctly. I also tried when offline and it also gets scrolled after the data from the request is applied. It happens when you hover over the chat navigating back.

Screen.Recording.2024-04-18.at.14.13.21.mp4

FYI: Piotr has been reassigned to another project from Callstack - me or someone from our team will take it over shortly and continue the investigation

[koko57]

@CortneyOfstad I'm continuing Piotr's investigation and what I've noticed is that removing shouldEnableAutoScrollToTopThreshold prop the list is not scrolled when going back. This

App/src/pages/home/report/ReportActionsView.tsx

Line 487 in 4654d6e

const shouldEnableAutoScroll = hasNewestReportAction && (!reportActionID || !isNavigatingToLinkedMessage);

is always true, so the list is autoscrolled to the bottom. Looks like hasNewestReportAction condition is always true as well (I wonder if there are cases that is not true). For me doesn't really makes sense as I think it should be true only right after we get a new unread message, after we read it it should be false.

I'll continue my investigation and think of a solution to suppress scrolling down when we don't get any new message.

[melvin-bot]

@JmillsExpensify, @CortneyOfstad, @mollfpr, @Piotrfj Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[CortneyOfstad]

@koko57 any update on your investigation? Thank you!

[koko57]

@CortneyOfstad sorry, I've been busy with my other high priority issue, I haven't had much time to work on this one since Monday. I will look at it today.

I think the root cause I've presented is correct, I don't think that there's another reason for this behaviour, so the only thing that I'm still thinking of is how to fix this issue.

[koko57]

Still looking for a proper solution

[CortneyOfstad]

@koko57 — any update on any solutions?

[koko57]

@CortneyOfstad Still working on it. I'm trying to understand why do we have these two const in both ReportActionsView and ReportActionsList

App/src/pages/home/report/ReportActionsView.tsx

Line 236 in 6a37cd8

const hasNewestReportAction = reportActions[0]?.created === report.lastVisibleActionCreated || reportActions[0]?.created === transactionThreadReport?.lastVisibleActionCreated;

App/src/pages/home/report/ReportActionsList.tsx

Line 203 in 6a37cd8

const hasNewestReportAction = sortedReportActions?.[0].created === report.lastVisibleActionCreated;

and why we would need them as they seem to be always true.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[koko57]

Still working on it

[CortneyOfstad]

Sounds good @koko57 👍

[CortneyOfstad]

@koko57 can you provide an update by EOD on where we're at with this? Thanks!

[koko57]

@CortneyOfstad I'm testing a few options, but still I don't quite understand the thing I mentioned here. Is there anybody who can help me with this one?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[koko57]

@CortneyOfstad I merged with main today - and I can't reproduce it on Android either. The page still scrolls on the web. If it's desired for the web I think we can close this issue

[CortneyOfstad]

Thanks @koko57! I agree and we can close this. Thanks!