[$500] Thread - Unable to send a reply in thread after leaving the thread in offline mode

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Go to workspace chat
2. Go offline.
3. Send a message and reply in thread.
4. Leave the thread.
5. Open the thread and send a reply again.

Expected Result:

User is able to send a reply in thread after leaving the thread in offline mode.

Actual Result:

User is unable to send a reply in thread after leaving the thread in offline mode.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339832_1705045271304.20240111_230544.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190e8891c6eb5ad7c
• Upwork Job ID: 1745748146336444416
• Last Price Increase: 2024-01-26
• Automatic offers:
• mollfpr | Reviewer | 28143176
• tienifr | Contributor | 28143177

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190e8891c6eb5ad7c

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is unable to send a reply in thread after leaving the thread in offline mode.

What is the root cause of that problem?

After leaving thread, we will delete the report along with report actions, that why if users want to visit again, we have to load it from BE -> In offline mode we just can see the loading page

What changes do you think we should make in order to solve the problem?

We should not delete the thread report/ report action after leaving thread, we just need to update the notification preference to not receive the notification.

In leaveRoom function:

    const optimisticData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
            value: {
                      notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
                  }
        },
    ];

we need to update successfulData as well.

Then navigate to the previous chat.

    if (isWorkspaceMemberLeavingWorkspaceRoom) {
...
else{
        Navigation.goBack(ROUTES.HOME);
}

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2024-01-12.at.17.29.59.mov

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread - Unable to send a reply inside of a thread after leaving the thread in offline mode

What is the root cause of that problem?

The canLeaveRoom function is used in the HeaderView component to display the leave room menu option.

App/src/pages/home/HeaderView.js

Lines 166 to 171 in a2864a0

	const isWorkspaceMemberLeavingWorkspaceRoom = lodashGet(props.report, 'visibility', '') === CONST.REPORT.VISIBILITY.RESTRICTED && isPolicyMember;
	threeDotMenuItems.push({
	icon: Expensicons.ChatBubbles,
	text: translate('common.leave'),
	onSelected: Session.checkIfActionIsAllowed(() => Report.leaveRoom(props.report.reportID, isWorkspaceMemberLeavingWorkspaceRoom)),
	});

I believe solely using isWorkspaceMemberLeavingWorkspaceRoom to create a condition in the leaveRoom function for this PR #33053 was not a good idea.

App/src/libs/actions/Report.ts

Lines 2092 to 2097 in f268c39

	value: isWorkspaceMemberLeavingWorkspaceRoom
	? {
	notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
	}
	: {
	reportID: null,

This is because PR removes the report.ReportID from the onyx if isWorkspaceMemberLeavingWorkspaceRoom is false.
Hence, threads are also affected.

App/src/pages/home/ReportScreen.js

Lines 250 to 251 in a2864a0

	const isTransitioning = report && report.reportID !== reportIDFromPath;
	return reportIDFromPath !== '' && report.reportID && !isTransitioning;

Therefore, isReportReadyForDisplay will always be false, and the ReportScreen will load infinitely.

App/src/pages/home/ReportScreen.js

Lines 517 to 518 in a2864a0

	{isReportReadyForDisplay && !isLoadingInitialReportActions && !isLoading && (
	<ReportActionsView

It is just not displaying the ReportActionsView component.

Finally, the user can not reply because of the ReportFooter component over here.

What changes do you think we should make in order to solve the problem?

Part 1

We will use the isChatThread function with the isWorkspaceMemberLeavingWorkspaceRoom variable to create a better condition.

App/src/libs/actions/Report.ts

Line 2092 in f268c39

value: isWorkspaceMemberLeavingWorkspaceRoom

Modify the above condition to something similar to the one below:

value: isWorkspaceMemberLeavingWorkspaceRoom || isChatThread(report)

App/src/libs/actions/Report.ts

Lines 2152 to 2154 in f268c39

	API.write('LeaveRoom', parameters, {optimisticData, successData, failureData});
	if (isWorkspaceMemberLeavingWorkspaceRoom) {

Part 2

Finally, we create a new condition after API.write shown above.
It will navigate the user back to the parent report.

if (isChatThread(report)) {
    Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(report.parentReportID));
}

Question
Is the navigating back part not supposed to happen for threads? 🤔
I added part 2 in case it was needed.

Result (macOS - Chrome)

296661827-ba321858-6fd0-49de-8e87-2ecb0eda39ae.mov

[joekaufmanexpensify]

Pending proposal reviews from @thesahindia

[joekaufmanexpensify]

Same

[thesahindia]

Sorry won't be able to take this. Please reassign!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[aldo-expensify]

Reassigned C+ since @eVoloshchak doesn't look active

[joekaufmanexpensify]

TY!

[mollfpr]

I'm sure this was expected behavior; I'll try to find the conversation and link here.

[joekaufmanexpensify]

DM'ed Georgia about proposal

[melvin-bot]

📣 @mollfpr 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[grgia]

All yours @tienifr

[joekaufmanexpensify]

@grgia mind confirming this question? Seems like the PR review is blocked on it.

[joekaufmanexpensify]

DM'ed Georgia about question on PR

[mollfpr]

We have another PR that fixed this issue, and the solution is kinda similar. I have checked the PR #37355, and it fixes this issue.

I think we can close the PR, but I don't know what the next process.

cc @joekaufmanexpensify

[joekaufmanexpensify]

Got it. I'll take a look.

[joekaufmanexpensify]

Discussing

[joekaufmanexpensify]

We discussed and landed on the following:

• @tienifr - $500 for contributor role, since you were hired for this job, wrote the PR, and the delay was on us internally. Paid via Upwork.
• @mollfpr - $250 for C+, since you reviewed proposals, but did not do a full review. Paid via NewDot.

[joekaufmanexpensify]

@tienifr $500 sent and contract ended!

[joekaufmanexpensify]

@mollfpr please accept our offer so we can pay you.

[joekaufmanexpensify]

I'm OOO the next two days, so we'll issue payment to @mollfpr on Monday (once you accept the offer).

[mollfpr]

Sorry for the late reply @joekaufmanexpensify I did manual request in NewDot.

[joekaufmanexpensify]

Ah, all good. I canceled the offer in upwork, and updated my post above to clarify that you're being paid via NewDot.

[joekaufmanexpensify]

Payment summary is here.

[joekaufmanexpensify]

All set!

[JmillsExpensify]

$250 approved for @mollfpr based on this summary.