[HOLD for payment 2024-01-02] [$500] Settings - Focus shifts to first digit on shortcut & back

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.13-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the app
2. Open settings->profile->contact methods
3. Open pending contact method or add new and open that contact method
4. Type in few digits in the code and use any of the keyboard shortcuts eg: CTRL+K, CTRL+J etc
5. Click on back and observe that app refocuses back to first magic code input instead on focusing on next empty magic code input OR the magic code input which was focused before opening keyboard shortcut

Expected Result:

App should focus back to next empty magic code input OR magic code input which was focused before opening keyboard shortcut on back from any keyboard shortcut

Actual Result:

App focuses on first magic code input on back from keyboard shortcut even though focus was on other magic code input before opening any keyboard shortcut

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6313245_1702568468462.windows_chrome_-_focus_back_on_first_digit_issue.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0143f494715bf21dfc
• Upwork Job ID: 1735693221598715904
• Last Price Increase: 2023-12-15
• Automatic offers:
• alitoshmatov | Reviewer | 28065220
• Krishna2323 | Contributor | 28065221

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0143f494715bf21dfc

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[artus9033]

Hi, I'm Artur from Callstack - expert contributor group - and I would like to work on this issue.

[melvin-bot]

📣 @artus9033! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Settings - Focus shifts to first digit on shortcut & back #33170

What is the root cause of that problem?

We always focus to the first input using useFocusEffect when page is mounted.

What changes do you think we should make in order to solve the problem?

Instead of focus inside useFocusEffect we can use focusLastSelected.

App/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js

Line 112 in 6fc070b

focusTimeoutRef.current = setTimeout(inputValidateCodeRef.current.focus, CONST.ANIMATED_TRANSITION);

Result

focus_last_selected_contact_method.mp4

[lschurr]

Could you review the proposal @alitoshmatov?

[alitoshmatov]

Reviewing

[alitoshmatov]

@Krishna2323 Your RCA is correct. Your solution solves a problem and straightforward

We can go with @Krishna2323 's proposal

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@alitoshmatov, PR ready for a review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Settings - Focus shifts to first digit on shortcut & back. #33366

If no regressions arise, payment will be issued on 2024-01-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment automatic offer (Reviewer)
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

@alitoshmatov could you work through the checklist on this one?

[alitoshmatov]

• The PR that introduced the bug has been identified: Magic code blur #28711
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake: https://github.com/Expensify/App/pull/28711/files#r1438392220
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner: No need for a discussion
• Determine if we should create a regression test for this bug: N/a

[lschurr]

Payment summary:

• Bug reporter: Applause (no payment)
• Contributor: @Krishna2323 $500
• Contributor+: @alitoshmatov $500

[lschurr]

Payments sent in Upwork. Closing this one out.