Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUSHAT TO REQUEST PAYMENT ON NEW.DOT] Payment issue for E/App PR#30117 #30753

Closed
melvin-bot bot opened this issue Nov 2, 2023 · 11 comments
Closed

[RUSHAT TO REQUEST PAYMENT ON NEW.DOT] Payment issue for E/App PR#30117 #30753

melvin-bot bot opened this issue Nov 2, 2023 · 11 comments
Assignees
@rushatgabhane @jliexpensify
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 2, 2023 •
edited
Loading

Issue created to compensate the Contributor+ member for their work on #30117
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @rushatgabhane.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0174c4b687c1067e65
  • Upwork Job ID: 1720020640732499968
  • Last Price Increase: 2023-11-02
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Nov 2, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Nov 2, 2023
@melvin-bot melvin-bot bot mentioned this issue Nov 2, 2023
Merged
59 tasks
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 2, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 2, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0174c4b687c1067e65

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 2, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 2, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 2, 2023

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

@jliexpensify
Copy link
Contributor

Payment Summary

Removing Upworks job!

@jliexpensify jliexpensify reopened this Nov 3, 2023
@jliexpensify jliexpensify added Weekly KSv2 and removed Daily KSv2 labels Nov 3, 2023
@jliexpensify
Copy link
Contributor

Actually, I should keep this open in case of regressions.

@jliexpensify jliexpensify changed the title Payment issue for E/App PR#30117 [RUSHAT TO REQUEST PAYMENT ON NEW.DOT] Payment issue for E/App PR#30117 Nov 3, 2023
@jliexpensify
Copy link
Contributor

Not deployed yet, shifting to Weekly

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 8, 2023
@jliexpensify
Copy link
Contributor

Deployed to prod 3 days ago. I'll wait until 17th Nov for regressions and close this out.

@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2023
@jliexpensify jliexpensify added Weekly KSv2 Overdue and removed Daily KSv2 labels Nov 12, 2023
@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2023
@rushatgabhane
Copy link
Member

Requested here https://staging.new.expensify.com/r/8089412385922238

@JmillsExpensify
Copy link

$500 payment approved for @rushatgabhane based on this comment.

@jliexpensify
Copy link
Contributor

Closing, there doesn't seem to be any regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rushatgabhane rushatgabhane

@jliexpensify jliexpensify

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Task Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JmillsExpensify @rushatgabhane @jliexpensify