[HOLD for payment 2023-10-30] [$500] DEV: Web - Console error on login

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: Dev 1.3.86.0
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697633043348869

Action Performed:

1. Logout if you already login
2. Enter email and magic code

Expected Result:

should not show console error

Actual Result:

console error appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-18.at.6.14.19.PM.mov

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b8af22ad298788b
• Upwork Job ID: 1714664714880716800
• Last Price Increase: 2023-10-18
• Automatic offers:
• fedirjh | Contributor | 27263678
• gadhiyamanan | Reporter | 27263681

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010b8af22ad298788b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console errors appears after login and automatic navigation to the ReportScreen.

What is the root cause of that problem?

ReportScreen is expecting the userLeavingStatus to a boolean.

                key: ({route}) => {
                    return `${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${getReportID(route)}`
                },

• Right after the login, getReportID(route) will return an empty string.
• The empty string passed to Onyx will cause it to return the whole object, something that looks like

{
userIsLeavingRoom_some_id: false
}

• The initial value here won't be applied because the results is there. it's just not the way we want it.

What changes do you think we should make in order to solve the problem?

Add this check. We only return the value from the collection when the reportID becomes available.

            userLeavingStatus: {
                key: ({route}) => {
                    if(!getReportID(route)) {
                        return false;
                    }

                    return `${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}${getReportID(route)}`
                },
                initialValue: false,
            },

What alternative solutions did you explore? (Optional)

N/A

[Pujan92]

@5war00p @fedirjh Seems a regression from #29590 where null is replaced with an empty string here. Now it returns the collection for reportUserIsLeavingRoom_ and reportActions_ due to an empty string which earlier returns undefined by considering reportUserIsLeavingRoom_null and reportActions_null I believe.

[parasharrajat]

Correct. It is a regression from #29590.

@adelekennedy Please assign @fedirjh as C+ to handle regression. There will only be reporting payment afterwards.

[melvin-bot]

📣 @parasharrajat Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[fedirjh]

cc @5war00p can you raise a PR to revert that extra change?

[5war00p]

@fedirjh you mean changing the value to empty string?

[b4s36t4]

What is the difference between reportActions_ and reportActions_null key that and that causes object to be returned? isn't it the RCA?

[5war00p]

Both are strings with and without null has prefix are explicitly checking the suffix null or not?
@fedirjh Here is the PR: #29893

[b4s36t4]

why is there a need to convert null to string? isn't that an issue? Just wondering about the underlying real issue.

[fedirjh]

you mean changing the value to empty string?

Yes , we should return null

What is the difference between reportActions_ and reportActions_null key that and that causes object to be returned?

it's how Onyx works :

• reportActions_ is a collection key, it will return a collection of reports actions
• reportActions_null will return an empty object

[b4s36t4]

Found the culprit, thanks for explaining @fedirjh :)

[fedirjh]

The code is tricky and that line should have included a comment explaining the difference and that we should require reportID to be null.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• revert: from empty string to null #29893

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @parasharrajat does not require payment (Eligible for Manual Requests)
• @fedirjh requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat / @fedirjh] Determine if we should create a regression test for this bug.
• [@parasharrajat / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[adelekennedy]

Payouts due:

Issue Reporter: $50 @gadhiyamanan Upwork

Based on comment here

[melvin-bot]

@fedirjh, @adelekennedy Huh... This is 4 days overdue. Who can take care of this?

[adelekennedy]

payments made! any more steps or are we good to close @fedirjh?

[fedirjh]

@adelekennedy Let's close, No need for regression test as this is a console error.