[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] Web - Wrong navigation after back from add-bank-account page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on your avatar to open settings
2. Click wallet > Then Add payment method > Then Bank account
3. Now Click on the browser back button

Expected Result:

User should return to the wallet page

Actual Result:

The user did not return to the wallet page, but instead went back to the settings page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71.4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.17-09-23.04_21_16.webm

Recording.4557.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694914706789169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01993d4f2d40318905
• Upwork Job ID: 1710721784525074432
• Last Price Increase: 2023-10-07

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ginsuma]

The regression is from my PR #26816
I am investigating it.

[Ahmed-Abdella]

@thienlnam Sorry jack the reporting bonus again

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix #27673 #27696

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ahmed-Abdella requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix #27673 #27696

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ahmed-Abdella requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Ahmed-Abdella]

@joelbettner Could you plz help me on reporting bonus for this issue (regression) if you have time?

[melvin-bot]

@joelbettner Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@joelbettner Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@joelbettner Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[aimane-chnaif]

@joelbettner or @thienlnam can you please add Bug label?
Reporting bonus and C+ review compensation is pending here.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01993d4f2d40318905

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[sakluger]

Summarizing payouts for this issue:

Bug reporter: @Ahmed-Abdella $50 (offer sent via Upwork)
Contributor+: @aimane-chnaif $500 (offer sent via Upwork)

Upwork job: https://www.upwork.com/jobs/~01993d4f2d40318905

@Ahmed-Abdella @aimane-chnaif I'll complete the payouts once you've accepted the Upwork offers, thanks!

[Ahmed-Abdella]

@sakluger I accepted the offer, thanks

[melvin-bot]

@sakluger, @joelbettner, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aimane-chnaif]

Accepted offer. Am I eligible for speed bonus?

[sakluger]

Sorry for the delay everyone! All paid up now.

@aimane-chnaif we don't have a speed bonus on internal issues, only external ones.

[aimane-chnaif]

"internal" is determined by PR author, not by label