[$500] Dev: Web - Inconsistence space between input fields in #Rooms

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon and select Send message option
2. Go to #Room tab
3. Check space between input fields

Expected Result:

Space should be consistence between input fields

Actual Result:

Space under Room name is more compare to other

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.70.5
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-16.at.10.37.38.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694840876055859

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01df923e800f40dae5
• Upwork Job ID: 1703144278120108032
• Last Price Increase: 2023-09-23

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Margin below room name is more than the bottom margin for other fields below

What is the root cause of that problem?

We are using a different margin here

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 171 in 76c1559

<View style={styles.mb5}>

which is different here

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 179 in 76c1559

<View style={styles.mb2}>

What changes do you think we should make in order to solve the problem?

We should use the same margin mb2 for all including room name input view.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01df923e800f40dae5

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue

Inputs have different distances between them

What is the root cause of that problem?

Different styles in inputs

What changes do you think we should make in order to solve the problem?

In this component we have the some inputs which have some different styles

App/src/pages/workspace/WorkspaceNewRoomPage.js

Lines 171 to 206 in 76c1559

	<View style={styles.mb5}>
	<RoomNameInput
	inputID="roomName"
	isFocused={props.isFocused}
	shouldDelayFocus
	autoFocus
	/>
	</View>
	<View style={styles.mb2}>
	<Picker
	inputID="policyID"
	label={translate('workspace.common.workspace')}
	placeholder={{value: '', label: translate('newRoomPage.selectAWorkspace')}}
	items={workspaceOptions}
	onValueChange={setPolicyID}
	/>
	</View>
	{isPolicyAdmin && (
	<View style={styles.mb2}>
	<Picker
	inputID="writeCapability"
	label={translate('writeCapabilityPage.label')}
	items={writeCapabilityOptions}
	defaultValue={CONST.REPORT.WRITE_CAPABILITIES.ALL}
	/>
	</View>
	)}
	<View style={styles.mb2}>
	<Picker
	inputID="visibility"
	label={translate('newRoomPage.visibility')}
	items={visibilityOptions}
	onValueChange={setVisibility}
	defaultValue={CONST.REPORT.VISIBILITY.RESTRICTED}
	/>
	</View>

To reduce potential errors, it would be a good idea to create a constant for styles so that you can change styles in only one place

Or create a wrapper component for the inputs

What alternative solutions did you explore? (Optional)

NA

[laurenreidexpensify]

@jjcoffee what you reckon about the proposal above?

[c3024]

Here is a proposal as well just in case it is missed @jjcoffee

[jjcoffee]

@c3024's proposal looks good - correct RCA and solution. I'm not 100% sure if this wasn't intentional, so we might want some design eyes to verify that we want to get rid of the spacing here.

@shawnborton or @dannymcclain Are we good to reduce the margin below the "Room name" input to match the other inputs?

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dannymcclain]

Looking at some other mocks with multiple inputs, I actually think the spacing between the Room name and Workspace inputs are what we want them all to have. Here's a random example:

@shawnborton can verify but I'm pretty sure we want to add space here, not remove it.

[jjcoffee]

@dannymcclain Ah so you're saying we should increase the spacing on all the other inputs instead?

[dannymcclain]

I believe so!

[c3024]

We use this between inputs

View style={styles.formSpaceVertical}

in address page so is this what we use here as well?

Edit: This is a different address page and different pages have different spacing. So we might use mb5 here for all then.

[shawnborton]

Yup, that makes sense to me. Though I think @dangrous is working on revamping this page right now so maybe we want to just close this issue out in favor of the work DGR is doing?

[dangrous]

Yep I can tackle that in my PR. Do you mind commenting with what it should be (looks like mb5 I think?) on this PR?

[shawnborton]

Can do. Okay, @laurenreidexpensify let's close this one down.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[gadhiyamanan]

@laurenreidexpensify i think this is eligible for reporting bonus because it will be handled in other PR after i reported this issue

[gadhiyamanan]

Bump @laurenreidexpensify