[HOLD for payment 2023-09-27] [$500] [Distance] - The i (Toggle attribution) button on the map does not show anything

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open request money
2. Open distance tab
3. Tap on i button on bottom right corner of the map

Expected Result:

The toggle attribution button should open options

Actual Result:

The toggle attribution button doesn't work when it is clicked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.63.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

i.mp4

Recording.4264.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jo-ui
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693894957986959

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012c7d2a65611a8d49
• Upwork Job ID: 1701779460806856704
• Last Price Increase: 2023-09-13
• Automatic offers:
• akinwale | Contributor | 26685843
• jo-ui | Reporter | 26685844

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The toggle attribution (i) button on the map does not show anything on web platforms (desktop web and mweb) and desktop.

What is the root cause of that problem?

The pan responder implemented for the View that contains the Map is intercepting all touch / click events since onStartShouldSetPanResponder is set to always return true, preventing the attribution button from working as it should on web and desktop (tapping or clicking the button should show the attribution text, refer to the Mapbox attribution guide for more details).

App/src/components/MapView/responder/index.ts

Lines 3 to 6 in edab657

	const responder = PanResponder.create({
	onStartShouldSetPanResponder: () => true,
	onPanResponderTerminationRequest: () => false,
	});

This is a regression from #26525.

What changes do you think we should make in order to solve the problem?

Modify the responder by adding an onMoveShouldSetPanResponder handler which returns true, and updating the onStartShouldSetPanResponder handler to return false.

const responder = PanResponder.create({
    onStartShouldSetPanResponder: () => false,
    onMoveShouldSetPanResponder: () => true,
    onPanResponderTerminationRequest: () => false,
});

Or just remove the onStartShouldSetPanResponder handler to avoid unnecessary code.

const responder = PanResponder.create({
    onMoveShouldSetPanResponder: () => true,
    onPanResponderTerminationRequest: () => false,
});

For Android native, we need to add an index.android.ts file for the responder which follows the original implementation in order to handle swiping from left to right properly within the map view.

const responder = PanResponder.create({
    onStartShouldSetPanResponder: () => true,
    onPanResponderTerminationRequest: () => false,
});

What alternative solutions did you explore? (Optional)

None.

[jo-ui]

This issue is now on the latest production too

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

@trjExpensify - what is that i supposed to show?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012c7d2a65611a8d49

[melvin-bot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[akinwale]

@trjExpensify - what is that i supposed to show?

mapbox-toggle-attribution.mp4

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The toggle attribution button doesn't work when it is clicked

What is the root cause of that problem?

In MapView, onStartShouldSetPanResponder: () => true, setting it to true (this is the root cause)

What changes do you think we should make in order to solve the problem?

Setting this onStartShouldSetPanResponder to false will solve the problem

What alternative solutions did you explore? (Optional)

NA

[trjExpensify]

@trjExpensify - what is that i supposed to show?

Yeah, that i is something that comes from mapbox the map provider. I doubt it, but @neil-marcellini @hayata-suenaga is there a way for us not to show the i at all. I appreciate the watermark will always have to be there, like how "Google" is in the bottom-left of the map in all of my ride sharing apps that use Google maps.

[akinwale]

Yeah, that i is something that comes from mapbox the map provider. I doubt it, but @neil-marcellini @hayata-suenaga is there a way for us not to show the i at all. I appreciate the watermark will always have to be there, like how "Google" is in the bottom-left of the map in all of my ride sharing apps that use Google maps.

Quoted from https://docs.mapbox.com/help/getting-started/attribution/:

Maps that use Mapbox map designs, data or software usually must display the Mapbox logo and text attribution.

[trjExpensify]

Got it, so this is what they call "text attribution" is it?

[akinwale]

Got it, so this is what they call "text attribution" is it?

Yes. The logo is displayed at the bottom-left, while text attribution is displayed at the bottom-right by default. On smaller screen widths, the bottom-right changes to an icon which you can click to reveal the text attribution.

[trjExpensify]

Cool, thanks.

[hayata-suenaga]

do you still need an input from me 😃 ?

[trjExpensify]

Ha, I think we're good thanks!

[allroundexperts]

Thanks for your proposal @PiyushChandra17. Unfortunately, I was not able to find any concrete difference between your and @akinwale's proposal.

@akinwale's proposal has the correct root cause and a working solution as well. Also, they were the first to provide a complete solution. Let's go with them!

🎀 👀 🎀 C+ reviewed

[akinwale]

@allroundexperts My PR is ready for review. Thanks.

[melvin-bot]

🎯 ⚡️ Woah @allroundexperts / @akinwale, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @akinwale got assigned: 2023-09-15 03:24:22 Z
• when the PR got merged: 2023-09-18 04:15:48 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: the toggle attribution (i) button does not show anything on web and desktop #27491

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment offer (Contributor) - $500+$250 urgency bonus
• @allroundexperts does not require payment (Eligible for Manual Requests) - - $500+$250 urgency bonus on ND
• @jo-ui requires payment offer (Reporter) - $50

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Julesssss]

Ready for payment @anmurali 👍

[Julesssss]

Ready for payment @anmurali 👍

Bumping for payment so we can close out this issue.

[anmurali]

Paid the reporter and contributor. Approved payment to C+ @allroundexperts for whenever he creates a ND request.

[allroundexperts]

@anmurali Can you please write the payment summary?

[anmurali]

#26761 (comment)
It's right here. Why do I need to re-write it?

[allroundexperts]

#26761 (comment)

It's right here. Why do I need to re-write it?

This doesn't include the exact amount. @JmillsExpensify we do need a written summary, right?

[anmurali]

Updated that entry with amounts

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.