[C+ Checklist Needs Completion] [$500] Inconsistency bug: "Assign task" appear in modal of "+" actions button in thread of flagging

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to a new conversation with User B
2. User A sends a message to User B
3. User B selects User A's "Flag Offensive" message -> choose any reason
4. User B replies in thread with Concierge
5. Click "+" button -> it shows "add attachment"
6. Click on any other chat and click back with the Concierge thread

Expected Result:

User should not be able to assign a task for Concierge.

Actual Result:

User can assign task in Concierge thread.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.58-0

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Kdb.mp4

Recording.6046.mp4

Expensify/Expensify Issue URL:

Issue reported by: @le Thi Thu Thuy

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692696877160359

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0197b4de7da68bcca2
• Upwork Job ID: 1697572011388342272
• Last Price Increase: 2023-09-08
• Automatic offers:
• jjcoffee | Reviewer | 26681642
• Pujan92 | Contributor | 26681644

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task option enabled for concierge thread chat

What is the root cause of that problem?

In the isExpensifyOnlyParticipantInReport function we are excluding the current user id but the filtered results length we are not considering which leads to the issue where the length of lodashGet(report, 'participantAccountIDs', []) gives 2 for this thread.

App/src/libs/ReportUtils.js

Lines 485 to 488 in 8650a9c

	function isExpensifyOnlyParticipantInReport(report) {
	const reportParticipants = _.without(lodashGet(report, 'participantAccountIDs', []), currentUserAccountID);
	return lodashGet(report, 'participantAccountIDs', []).length === 1 && _.some(reportParticipants, (accountID) => _.contains(CONST.EXPENSIFY_ACCOUNT_IDS, accountID));
	}

What changes do you think we should make in order to solve the problem?

We can use reportParticipants.length in the condition to check the filtered participants array. With this, for the scenario where the user tries to reply in a thread for the flagged message it only considers the Concierge id.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0197b4de7da68bcca2

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[greg-schroeder]

Awaiting proposal review, not overdue

[Santhosh-Sellavel]

@greg-schroeder

Less Bandwidth. So unassigning to move this forward as it has proposals already. Assign a new C+ Reapplying external label, Thanks!

[greg-schroeder]

Okay, I will find a new C+

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[jjcoffee]

Reviewing tomorrow!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: "Assign task" appear in modal of "+" actions button in thread of flagging #27552

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment offer (Contributor)
• @jjcoffee requires payment offer (Reviewer)
• @le requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Issue Participants:

Issue reported by: @thuyle04
Contributor: @Pujan92
C+: @jjcoffee

Was this issue merged in time to be eligible for the speed bonus? yes
Were their any regressions? no

Payment summary:

Reporter: $50
Contributor: $750
C+: $750

[greg-schroeder]

@jjcoffee and @Pujan92 paid - Offer sent to @thuyle04

[greg-schroeder]

@jjcoffee please complete the checklist and we'll close this out!

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: Task Share Destination Fixes #24019
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Task Share Destination Fixes #24019 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - just needed more thorough testing.
• Determine if we should create a regression test for this bug. No - low impact.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[jjcoffee]

@greg-schroeder Checklist complete!

[melvin-bot]

@Pujan92, @cristipaval, @jjcoffee, @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[cristipaval]

@jjcoffee and @Pujan92 paid - Offer sent to @thuyle04

Is @thuyle04 paid already? Can we close the issue?

[cristipaval]

👀

[thuyle04]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01fcd9ed589276332f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[greg-schroeder]

Wow, sorry, for some reason it wasn't showing in my upwork UI - I went through and had to pay it directly @thuyle04

[greg-schroeder]

Taking care of checklist and closing