-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-01-16] [TS migration] Migrate 'PopoverWithMeasuredContent.js' component to TypeScript #25053
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Hi, |
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Triggered auto assignment to @jliexpensify ( |
Going to take over as the PR is ready |
@eVoloshchak is paid through NewDot, can you request $250 and note here? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-01-05. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Linking the comment here which I believe is a regression. |
Thanks! @eVoloshchak can you check this out? Thanks! |
PR with the fix is open |
Payment Summary
|
Moving to weekly, waiting to be deployed to prod. |
Deployed to PROD - Payment date is 16th January. For JMills: Payment summary here |
$125 approved for @eVoloshchak based on this summary. |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
Issue Owner
Current Issue Owner: @jliexpensifyThe text was updated successfully, but these errors were encountered: