Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-16] [TS migration] Migrate 'PopoverWithMeasuredContent.js' component to TypeScript #25053

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/PopoverWithMeasuredContent.js 11
Issue OwnerCurrent Issue Owner: @jliexpensify
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@pasyukevich
Copy link
Member

Hi,
I'm Eugene from Callstack - an expert contributor group
I’d like to work on this issue

@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Copy link
Author

melvin-bot bot commented Dec 20, 2023

Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mountiny mountiny added NewFeature Something to build that is a new item. and removed Task labels Dec 28, 2023
Copy link
Author

melvin-bot bot commented Dec 28, 2023

@mountiny
Copy link
Contributor

Going to take over as the PR is ready

@mountiny
Copy link
Contributor

@eVoloshchak is paid through NewDot, can you request $250 and note here?

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 29, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'PopoverWithMeasuredContent.js' component to TypeScript [HOLD for payment 2024-01-05] [TS migration] Migrate 'PopoverWithMeasuredContent.js' component to TypeScript Dec 29, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 29, 2023
Copy link
Author

melvin-bot bot commented Dec 29, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Dec 29, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.19-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Dec 29, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@eVoloshchak] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@Pujan92
Copy link
Contributor

Pujan92 commented Jan 1, 2024

Linking the comment here which I believe is a regression.

@jliexpensify
Copy link
Contributor

Thanks! @eVoloshchak can you check this out? Thanks!

@pasyukevich
Copy link
Member

@eVoloshchak @jliexpensify

PR with the fix is open
#33835

@jliexpensify
Copy link
Contributor

Payment Summary

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 5, 2024
@jliexpensify jliexpensify added Weekly KSv2 and removed Daily KSv2 labels Jan 8, 2024
@jliexpensify
Copy link
Contributor

Moving to weekly, waiting to be deployed to prod.

@jliexpensify
Copy link
Contributor

jliexpensify commented Jan 10, 2024

Deployed to PROD - Payment date is 16th January.

For JMills: Payment summary here

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Jan 10, 2024
@jliexpensify jliexpensify changed the title [HOLD for payment 2024-01-05] [TS migration] Migrate 'PopoverWithMeasuredContent.js' component to TypeScript [HOLD for payment 2024-01-16] [TS migration] Migrate 'PopoverWithMeasuredContent.js' component to TypeScript Jan 10, 2024
@JmillsExpensify
Copy link

$125 approved for @eVoloshchak based on this summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

7 participants