Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] [TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #25010

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 25 comments
Closed

[$250] [TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #25010

melvin-bot bot opened this issue Aug 16, 2023 · 25 comments
Assignees
@cubuspl42 @AndrewGable @sonialiap
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/FullscreenLoadingIndicator.js 6
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 11, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@MaciejSWM
Copy link
Contributor

Hey! I’m Maciej Dobosz from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2023
@MaciejSWM MaciejSWM mentioned this issue Oct 19, 2023
Merged
57 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Monthly KSv2 labels Oct 26, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 30, 2023

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@roryabraham roryabraham moved this from Todo to In Progress in Typescript migration Nov 8, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 22, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 22, 2023

This issue has not been updated in over 15 days. @AndrewGable eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 22, 2023
@cubuspl42
Copy link
Contributor

@AndrewGable

This issue can be closed soon, as the PR is merged.

Am I eligible for payment for reviewing and testing the code? (Reviewer Checklist)

@AndrewGable AndrewGable changed the title [TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript [$250] [TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript Nov 27, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 27, 2023

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@AndrewGable
Copy link
Contributor

Yes, assigned and payment attached to title

@cubuspl42
Copy link
Contributor

@AndrewGable Thanks! What steps are necessary to close this, as the PR is reviewed & merged? Does the message by Melvin above mean we have to assign a BZ member? ^

@AndrewGable AndrewGable added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 28, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 28, 2023

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 28, 2023
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Nov 28, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot removed the Monthly KSv2 label Nov 28, 2023
@AndrewGable
Copy link
Contributor

@sonialiap - Please pay C+ $250 and then close issue. Thanks!

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 5, 2023

@cubuspl42, @AndrewGable, @sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 6, 2023

@cubuspl42, @AndrewGable, @sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 8, 2023

@cubuspl42, @AndrewGable, @sonialiap Eep! 4 days overdue now. Issues have feelings too...

@cubuspl42
Copy link
Contributor

@sonialiap Would you give it a look so we can close this? Thanks

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 19, 2023

@cubuspl42, @AndrewGable, @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Dec 21, 2023

@cubuspl42, @AndrewGable, @sonialiap Eep! 4 days overdue now. Issues have feelings too...

@cubuspl42
Copy link
Contributor

@AndrewGable @sonialiap Bump?

@AndrewGable
Copy link
Contributor

Sorry @cubuspl42 - This is blocked on @sonialiap. Hopefully after the holidays we can resolve this one.

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 1, 2024

@cubuspl42, @AndrewGable, @sonialiap Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 1, 2024

@cubuspl42, @AndrewGable, @sonialiap Eep! 4 days overdue now. Issues have feelings too...

@cubuspl42
Copy link
Contributor

@sonialiap Would you process the payment when you have a spare moment, please? It's an old thing, and it's an unnecessary notification noise. Thanks!

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 9, 2024

@cubuspl42, @AndrewGable, @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot Melvin Bot
Copy link
Author

melvin-bot bot commented Jan 11, 2024

@cubuspl42, @AndrewGable, @sonialiap Huh... This is 4 days overdue. Who can take care of this?

@sonialiap
Copy link
Contributor

$250 payment sent ✔️

@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cubuspl42 cubuspl42

@AndrewGable AndrewGable

@sonialiap sonialiap

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review Task Typescript Migration
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cubuspl42 @AndrewGable @sonialiap @MaciejSWM