[HOLD for payment 2023-09-29] [$2000] Web - user not able to save last enable date of birth

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Set the Date & Time on your Mac to India Standard Time
   a. On Mac > System Settings > General > Date & Time
   b. Enable "set time and date automatically" & Disable "Set time zone automatically using your current location"
   c. Choose New Delhi - India as your "Closest City"
   d. Disable "set time and date automatically"

2. Sign into https://staging.new.expensify.com/settings on the Chrome browser

3. Click the Profile icon (settings) > Profile > Personal details > Date of birth

4. Select the most recent available date

5. Notice date error

Expected Result:

user should able to save enable date

Actual Result:

error appears on select latest enable date

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.53-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-08.at.6.09.45.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan & @Pujan92
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691498421013379

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011fd6c960bd909251
• Upwork Job ID: 1689782476244590592
• Last Price Increase: 2023-08-24
• Automatic offers:
• 0xmiroslav | Reviewer | 26685187
• gadhiyamanan | Reporter | 26685188

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mvtglobally]

I wasn't able to reproduce, Not sure if this is account specific. Since its potential blocker, please double check

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[gadhiyamanan]

Try with new user if not able to reproduce

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selecting last enabled date of birth shows error

What is the root cause of that problem?

We recently updated to date-fns in getAgeRequirementError but we changed the currenDate to start of the day here

const currentDate = startOfDay(new Date());

so currentDate here starts at 00:00 GMT and
testdate here takes the corresponding zone time here +05:30

const testDate = new Date(date);

so it gives an error

What changes do you think we should make in order to solve the problem?

We should change this to

const currentDate =new Date();

What alternative solutions did you explore? (Optional)

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - user not able to save last enable date of birth

What is the root cause of that problem?

This code block gets triggered

App/src/libs/ValidationUtils.js

Lines 227 to 229 in dd21a0b

	if (isSameDay(testDate, recentDate) || isAfter(testDate, recentDate)) {
	return ['privatePersonalDetails.error.dateShouldBeBefore', {dateString: format(recentDate, CONST.DATE.FNS_FORMAT_STRING)}];
	}

What changes do you think we should make in order to solve the problem?

We can change maxDate to this in DateOfBirthPage
maxDate={moment().subtract(CONST.DATE_BIRTH.MIN_AGE, 'years').subtract(1, 'days').toDate()}

or We can fix it directly in getAgeRequirementError By changing recentDate

const recentDate = addDays(subYears(currentDate, minimumAge), 1)

or we can use date-fns to set maxDate to one day before so we don't have same day error.

What alternative solutions did you explore? (Optional)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not able to select the max date for non UTC timezone users

What is the root cause of that problem?

Here we have the difference in time which causes this condition isWithinInterval to be falsy. We are comparing the currentDate with the start time of day with testDate without the start time of the day which won't make the testDate in within the interval and it passed that if block.

App/src/libs/ValidationUtils.js

Line 224 in dd21a0b

if (isWithinInterval(testDate, {start: longAgoDate, end: recentDate})) {

What changes do you think we should make in order to solve the problem?

We need to add startOfDay for the testDate also to compare the dates correctly which considers the correct timestamp.

const testDate = startOfDay(new Date(date));

App/src/libs/ValidationUtils.js

Line 220 in dd21a0b

const testDate = new Date(date);

[Christinadobrzyn]

I can't reproduce either - asking for more guidance in the Slack thread - https://expensify.slack.com/archives/C049HHMV9SM/p1691509966704559?thread_ts=1691498421.013379&cid=C049HHMV9SM

[puneetlath]

I don't think this needs to be a deploy blocker as it only affects users who are exactly 5 years old. Removing the label.

[Pujan92]

I can't reproduce either - asking for more guidance in the Slack thread -

@Christinadobrzyn It can be reproducible for the GMT+ timezones. for GMT- it won't be reproducible as it(current code) considers previous day for the error condition.

[Pujan92]

For Mac these are the steps to update timezone and set any GMT+ city.

1. Select "System Preferences" from the Apple menu.
2. Under the "Date and Time" option, click on "Time Zone."
3. Deselect the "Set Time Zone Automatically Using Current Location" and update the city manually.

Screen.Recording.2023-08-09.at.5.13.33.PM.mp4

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[blazejkustra]

@0xmiroslav The PR is ready for review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - user not able to save last enable date of birth #26271

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @0xmiroslav requires payment offer (Reviewer)
• @gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

@0xmiroslav is there a regression for this? Let me know and I'll pay this out

Payouts will be:

Issue Reporter: $250 @gadhiyamanan (old pricing)
Contributor: NA @blazejkustra (contractor)
Contributor+: $2000 + $1000 bonus @0xmiroslav (old pricing)

Eligible for 50% #urgency bonus? Y - #24266 (comment)

Upwork job is here.

[0xmiros]

Contributor was assigned on Sep 14
C+ approved on Sep 16
PR merged on Sep 18 without changes requested
Sep 16, 17 was weekend

So I'd say actual timeline is within 2 days

[0xmiros]

No need regression test.
This is super edge case. No one will likely to select their age as 5 (min) or 150 (max).

[Christinadobrzyn]

@gadhiyamanan it looks like you might need to accept the offer - https://www.upwork.com/jobs/~011fd6c960bd909251
@0xmiroslav let me know how you'd like to be paid. Is this your new profile? https://www.upwork.com/nx/wm/offer/26685187

[0xmiros]

@Christinadobrzyn here's discussion about my payment - https://expensify.slack.com/archives/C01SKUP7QR0/p1692226249296529?thread_ts=1691559426.466079&cid=C01SKUP7QR0

[gadhiyamanan]

@Christinadobrzyn offer accepted, thanks!

[Gonals]

All done here?

[Christinadobrzyn]

Sorry for the delay here -

@gadhiyamanan I've paid you in Upwork based on this payment structure.

@0xmiroslav thanks for the Slack link it sounds like your Upwork account has been restored and we're paying you directly.

What is the Upwork link for your restored account so I can pay you through Upwork for this? Thanks!

[0xmiros]

@Christinadobrzyn please hold my payment yet and just close the issue. I am tracking myself and will ping here once ready.

[Christinadobrzyn]

Okay sounds good! Closing for now @0xmiroslav please let me know if you need any help with payment in the future.