mWeb - Extra margin above country textbox in country selection screen

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on settings -> Click profile
2. Click on Personal details -> Click Home address
3. Click country

Expected Result:

There should regular margin above country textfield

Actual Result:

Shows extra margin above country textfield

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.46-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1690402524.mp4

Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690402755216219

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[daordonez11]

Same RCA than #22560 it is fixed with #23538

cc @cead22 who approved fixing PR

[johncschuster]

Thanks for calling that out, @daordonez11!

[DanutGavrus]

@daordonez11 @johncschuster
PR has been deployed to staging. This reported issue seems fixed by it now. Could you confirm?

[johncschuster]

@kbecciv, can you try reproducing the behavior on staging to see if it persists?

[johncschuster]

@kbecciv bump!

[johncschuster]

Bump!

[DinalJivani]

@johncschuster
@kbecciv isn’t available from last few days.

I tested this issue and I see it has been fixed with other PR.

[johncschuster]

Thanks @DinalJivani. Are you able to locate the PR that fixed this behavior?

[DanutGavrus]

@johncschuster I think it's this one #23538 as it reduced the bottom margin which fixed #22560 and removed the top margin which fixed this issue #23761 in advance.

[DinalJivani]

Same RCA than #22560 it is fixed with #23538
cc @cead22 who approved fixing PR

as mentioned here I think above PR resolved this issue

[melvin-bot]

@johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[johncschuster]

Ok! It looks like this behavior is no longer reproducible. Closing!