[hold for payment 28 April] IOS - Secondary log in - "Done" button is not present to close keyboard

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Expected Result:

User should be able to see "send verification" button
user should be able to hide keyboard

Actual Result:

User is unable to see "send verification" button
User is unable to hide keyboard

Action Performed:

1. Open app
2. Login too account without secondary login
3. Navigate to profile settings
4. Click + to add phone number
5. enter valid phone
6. Start to enter password
7. try to close keyboard
8. After entering valid password try to click send verification button

Workaround:

Yes, user has to close the keyboard by tapping outside the field.

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android
Desktop App
Mobile Web

Version Number: 1.0.19-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Video

Expensify/Expensify Issue URL:

[MelvinBot]

Triggered auto assignment to @davidcardoza (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[davidcardoza]

Tested and ran into the same issue. Removing assignment and putting in the engineering queue.

[MelvinBot]

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alex-mechler]

Looks like a good one for a contributor to take 👍

[MelvinBot]

Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[SofiedeVreese]

Going to remove the Exported label for now (and removing @Beamanator 's assignment) to clarify the following:

@alex-mechler is this similar to this issue? It feels similar?

cc @marcaaron

[marcaaron]

Looks unrelated to me @SofiedeVreese

[SofiedeVreese]

Ok thanks for confirming @marcaaron I'll push this out to Upwork now.

[MelvinBot]

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[SofiedeVreese]

Readding Exported Label.

Upwork job posting: https://www.upwork.com/jobs/~014f5a3f656dd883ff

[rafidaky]

Hey, i have a proposal for this issue. I think the best way to handle this is to wrap the components in a KeyboardAvoidingView and enable it just for ios. So this way Send Validation button will be on top of the keyboard & accessible.

[parasharrajat]

This issue can easily be fixed by passing the returnKeyType as Done to TextInput on the PasswordPage.
https://github.com/Expensify/Expensify.cash/blob/a4aa60ad2b220e2a1ecf37c5e2768733dc82f149/src/pages/settings/PasswordPage.js#L80-L89

[marcaaron]

Not sure that's correct @parasharrajat. The green button is hidden behind the keyboard when it should be floating above the keyboard?

[parasharrajat]

Oh. I think the issue description is misleading. Though issue also says to add this.

[roryabraham]

@rafidaky Could you explain your proposal in a bit more detail?

[rafidaky]

https://github.com/Expensify/Expensify.cash/blob/011c66af622349d115fc6c1c8d0c187fe197b422/src/pages/settings/AddSecondaryLoginPage.js#L98
I'm suggesting we wrap everything in this ScreenWrapper component in a KeyboardAvoidingView so there won't be a need for the Done button and screen will look like this when password is focused:

[roryabraham]

Okay @rafidaky, your proposal looks good. Feel free to submit a pull request.

[SofiedeVreese]

Above contributor has been hired!

[SofiedeVreese]

PR is merged. Payment due on 28 April assuming no regressions.

[SofiedeVreese]

Checked with @roryabraham but no regressions so looks good to pay out.

[SofiedeVreese]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.