[$1000] [HOLD for payment 2023-08-02] Web - Space between the last message and time is more

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Send any message

Expected Result:

Space between the last message and time should be less

Actual Result:

Space between the last message and time is more

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.43-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689762849787649

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01349987aae27d2cdd
• Upwork Job ID: 1691158136170807296
• Last Price Increase: 2023-08-14

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Space between time and composer too much.

What is the root cause of that problem?

We're adding a vertical padding after this PR got merged. This can be seen in the pr diff here.

What changes do you think we should make in order to solve the problem?

We should change the following:

contentContainerStyle={[styles.chatContentScrollView, shouldShowReportRecipientLocalTime]}

to:

contentContainerStyle={[styles.chatContentScrollView, shouldShowReportRecipientLocalTime && styles.pt0]}

What alternative solutions did you explore? (Optional)

None

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

More space between the composer and last message

What is the root cause of that problem?

We are not taking out the padding here which we used to do earlier.

App/src/pages/home/report/ReportActionsList.js

Line 172 in fa473e9

contentContainerStyle={[styles.chatContentScrollView, shouldShowReportRecipientLocalTime]}

What changes do you think we should make in order to solve the problem?

As the flex direction is the column-reverse we need to take out the top padding by updating the condition to
shouldShowReportRecipientLocalTime && styles.pt0

Seems the conditional style by mistake taken out here in this PR

[jasperhuangg]

This looks like a regression, I'm going to see if I can find the PR that caused this and get the original author to fix it cc @marcochavezf

This also doesn't need to be a deploy blocker since it's a minor display bug

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[jasperhuangg]

cc @grgia this seems to be a regression from your PR, do you mind fixing this in a follow up?

[0xmiros]

If it's not a deploy blocker, I think it's better to tackle this in #22389

[grgia]

PR up

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix padding above time stamp in report view #23244

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[gadhiyamanan]

@grgia @marcochavezf can we assign any BZ member for payment ?

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[marcochavezf]

Hi @puneetlath, can you make the payment here, please? #23187 (comment)

[puneetlath]

Yes, sure thing. If I understand correctly from what I'm seeing this was handled internally, correct? So we need to pay $250 to @gadhiyamanan for the bug report and $1k to @situchan for C+. Does that sound right?

[situchan]

Yes, sure thing. If I understand correctly from what I'm seeing this was handled internally, correct? So we need to pay $250 to @gadhiyamanan for the bug report and $1k to @situchan for C+. Does that sound right?

yes correct

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01349987aae27d2cdd

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

[puneetlath]

Ok thanks for confirming. Sent offers.

[gadhiyamanan]

@puneetlath offer accepted, thanks!

[puneetlath]

All paid!