[HOLD for payment 2023-08-10] [$1000] Web - infinite loop on click of back button when go to connect bank account page of deleted policy

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Workspaces
2. Go to any policy > bank account
3. Copy the browser url
4. Go back to policy page and delete workspace
5. Paste the url in browser
6. Click on back button

Expected Result:

After clicking back button from "hmm... it's not here" page, we'd navigate to the Workspaces page (https://staging.new.expensify.com/settings/workspaces). Then, clicking back from there would navigate to the settings page.

Actual Result:

Infinite loop on click of back button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-9
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-18.at.6.14.24.PM.mov

Recording.3741.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689684394065279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0105141c978bfd9133
• Upwork Job ID: 1683596190818557952
2023-07-24
• Automatic offers:
• situchan | Reviewer | 25815017
• ginsuma | Contributor | 25815018
• gadhiyamanan | Reporter | 25815022

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - infinite loop on click of back button when go to connect bank account page of deleted policy

What is the root cause of that problem?

We are using Navigation.navigate for FullPageNotFoundView in ReimbursementAccountPage. This make the page is placed bottom in the stack navigator. When we keep clicking back button from WorkspacesListPage that is Navigation.goBack without shouldEnforceFallback flag => return to ReimbursementAccountPage

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 338 to 340 in 2d2008a

	<FullPageNotFoundView
	shouldShow
	onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)}

App/src/pages/workspace/WorkspacesListPage.js

Lines 175 to 177 in 2d2008a

	<HeaderWithBackButton
	title={translate('common.workspaces')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

What changes do you think we should make in order to solve the problem?

Change this LOC to:

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WORKSPACES)}

[yh-0218]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - infinite loop on click of back button when go to connect bank account page of deleted policy

What is the root cause of that problem?

Because of using Navigation.navigate for FullPageNotFoundView in ReimbursementAccountPage

What changes do you think we should make in order to solve the problem?

We can remove onBackButtonPress={() => Navigation. navigate(ROUTES.SETTINGS)} from FullPageNotFoundView in ReimbursementAccountPage to hide the model

What alternative solutions did you explore? (Optional)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Infinite loop on click of back button when go to connect bank account page of deleted policy

What is the root cause of that problem?

In ReimbursementAccountPage, when we click on the back button of page not found, we use Navigation.navigate. That makes this page doesn't unmount

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 340 in 2d2008a

onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)}

And then, We call navigate back function with fallbackRoute as setting route but we don't pass shouldEnforceFallback as true which makes this condition false because we already have a page in stack and then we navigate back to the previous page

App/src/pages/workspace/WorkspacesListPage.js

Lines 175 to 177 in 2d2008a

	<HeaderWithBackButton
	title={translate('common.workspaces')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

What changes do you think we should make in order to solve the problem?

We can add shouldEnforceFallbackc as true when we call Navigate.goBack function here to go back the fallbackRoute with replacing the previous page

Navigation.goBack(ROUTES.SETTINGS, true)

App/src/pages/workspace/WorkspacesListPage.js

Lines 175 to 177 in 2d2008a

	<HeaderWithBackButton
	title={translate('common.workspaces')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

What alternative solutions did you explore? (Optional)

We also can call Navigation.navigate here instead of Navigation.goBack

Navigation.navigate(ROUTES.SETTINGS)

App/src/pages/workspace/WorkspacesListPage.js

Lines 175 to 177 in 2d2008a

	<HeaderWithBackButton
	title={translate('common.workspaces')}
	onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

I agree with expectation in GH issue: Hide the model on click of back button from "hmm... it's not here" page if we're visit the page by direct link.

What is the root cause of that problem?

As other proposal already pointed out, in the ReimbursementAccountPage, we always navigate to WS setting when page not found

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 340 in 6bcd184

onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)}

And in WS setting page, we goBack to previous page if we click on back arrow in top head

App/src/pages/workspace/WorkspacesListPage.js

Line 177 in 6bcd184

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)}

In this case, it will back to previous page not found => Loop

What changes do you think we should make in order to solve the problem?

I agree with expectation in GH issue: Hide the model on click of back button from "hmm... it's not here" page if we're visit the page by direct link. So in order to do it, in this callback button

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Line 340 in 6bcd184

onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WORKSPACES)}

We need to check if we're visit this page by direct link (I think we can verify it by checking current route is the first/top one using getActiveRouteIndex(navigationRef.current.getState(), same way we check in Navigation.goBack until), then we call Navigation.dismissModal to close RHN. Otherwise, we navigate to WS setting as it is.

[anmurali]

OOO for 10 days

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[joekaufmanexpensify]

Reproduced! I updated OP as the expected behavior here should be that when the user clicks back on the Hm, it's not here page, we navigate back to the workspaces page. And then if they click back from there, back to the Settings page.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0105141c978bfd9133

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[joekaufmanexpensify]

Pending review of proposals

[joekaufmanexpensify]

@situchan Could you provide an update on your review of these proposals when you have a chance?

[joekaufmanexpensify]

Pending update

[joekaufmanexpensify]

Bumped in Slack.

[melvin-bot]

📣 @ginsuma 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[ginsuma]

Thanks for accepting my proposal. The PR #23843 is ready for review.
cc: @situchan @luacmartins

[melvin-bot]

🎯 ⚡️ Woah @situchan / @ginsuma, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @ginsuma got assigned: 2023-07-28 18:48:32 Z
• when the PR got merged: 2023-07-31 18:37:13 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix FullPageNotFoundView in ReimbursementAccountPage #23843

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ginsuma requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR: Fix: Deleting workspace in connect bank account provides update currency error #21819
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21819/files#r1288606613
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

@situchan mind completing the BZ checklist here when you have a sec?

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Fix: Deleting workspace in connect bank account provides update currency error #21819
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21819/files#r1288606613
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

We can now detect such issues in PR stage thanks to this new checklist item:

• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.

[joekaufmanexpensify]

Great, thanks! BZ checklist is complete. All set to issue payment tomorrow.

[joekaufmanexpensify]

This qualified for a speed bonus, so we need to make the following payments:

• @ginsuma $1,500 ($1,000 for PR, and $500 speed bonus).
• @situchan $1,500 ($1,000 for C+ review, and $500 speed bonus).
• @gadhiyamanan $250 for reporting bonus.

[joekaufmanexpensify]

All three offers are accepted in Upwork, so we'll issue payment tomorrow, and then close this out!

[joekaufmanexpensify]

@ginsuma $1,500 sent and contract ended!

[joekaufmanexpensify]

@situchan $1,500 sent and contract ended!

[joekaufmanexpensify]

@gadhiyamanan $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!