[HOLD for payment 2023-08-07] [$1000] Chat - Extra line breaks added when pasting text from code editor

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Navigate to staging.new.expensify.com
2. Copy the text from code editor:

   App/src/components/TextInputFocusable/index.js

   Lines 263 to 267 in 403fc28

   	if (files.length > 0) {
   	// Prevent the default so we do not post the file name into the text box
   	event.preventDefault();
   	this.props.onPasteFile(event.clipboardData.files[0]);
   	return;

3. Paste the text in the compose box of a conversation in New Expensify

Expected Result:

Pasted text should be correctly displayed with the expected line breaks in the compose box

Actual Result:

Pasted text should be correctly displayed - extra line breaks added when pasting text from code editor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.40.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6127859_Recording__365.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b57bc0495e0f6542
• Upwork Job ID: 1683569394738528256
2023-07-24
• Automatic offers:
• | | 0
• s-alves10 | Contributor | 25757442

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra line breaks added when pasting text from code editor on windows

What is the root cause of that problem?

End of line(EOL) is represented differently on various platforms. On Unix-like systems including Mac OS, \n is the code for EOL, and \r\n is the code for EOL on Windows.
We are using \n in the ExpensiMark now. When addComment API is called, we replace markdown with html elements and below rule is applied.

App/src/libs/ReportUtils.js

Line 1308 in a2dc004

const commentText = getParsedComment(text);

So EOL(\r\n on Windows) is converted to \r<br /> and \n<br /> is returned from the backend.

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to handle \r\n or \n as EOL in parsing markdown

The current newline rule is as follows

            {
                name: 'newline',
                regex: /\n/g,
                replacement: '<br />',
            },

Replace this with

            {
                name: 'newline',
                regex: /\r?\n/g,
                replacement: '<br />',
            },

This works as expected.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[anmurali]

Cannot reproduce

[s-alves10]

@anmurali
I'm not sure why this issue was closed. This is still reproducible on staging

22890.mp4

[kbecciv]

QA team is reproduced on build 1.3.43.1

singlelinebrk.mp4

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[slafortune]

Thanks for the reproduction!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b57bc0495e0f6542

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[s-alves10]

@rushatgabhane

PR is ready for review

[rushatgabhane]

yayy, we merged everything in 24 hrs

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: expensify-common version for window-style newline #23628

If no regressions arise, payment will be issued on 2023-08-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligable for Manual Requests)
• @s-alves10 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: N.A. This bug was always present and won't happen again because of the unit tests in expensify-common.

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Created a manual request - https://staging.new.expensify.com/r/7966456959101740

[Julesssss]

Can we complete the checklists? Is that the only blocker here?

[JmillsExpensify]

@slafortune Mind summarizing the appropriate payouts for everyone?

[JmillsExpensify]

@slafortune Friendly bump on the payment summary.

[rushatgabhane]

I think this qualifies for a bonus - #22890 (comment)

[slafortune]

Shoot! Sorry all, not sure how I've missed this!

• External issue reporter - Applause, no payment needed
• Contributor that fixed the issue - @s-alves10 - $1500 with speed bonus - PD via Upworks
• Contributor+ that helped on the issue and/or PR - @rushatgabhane - $1500 with speed bonus - Eligable for Manual Requests

[JmillsExpensify]

Reviewed the details for @rushatgabhane. Approved for payment in NewDot based on the above BZ summary.