Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign task - The word title is not translated into Spanish in chat #22684

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 11, 2023 · 5 comments
Closed
1 of 6 tasks
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with any account
  3. Change the language of the app to Spanish
  4. Click on FAB button -> Create a new task

Expected Result:

The word title is not translated into Spanish as titulo

Actual Result:

The word title is not translated into Spanish in chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6124090_1107

Expensify/Expensify Issue URL:

**Issue reported by:**Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jul 11, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thienlnam
Copy link
Contributor

This is getting fixed in #22586

@ahmdshrif
Copy link
Contributor

ahmdshrif commented Jul 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

title not translate to Spanish

What is the root cause of that problem?

we set title as staring not with translate function .

What changes do you think we should make in order to solve the problem?

we need to change this

<Text style={styles.taskTitleDescription}>Title</Text>

to

    <Text style={styles.taskTitleDescription}>{props.translate('task.title')}</Text>

What alternative solutions did you explore? (Optional)

N/A

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Jul 11, 2023
@jasperhuangg
Copy link
Contributor

known issue, got a fix for it here, @NikkiWines gonna close this out since we shouldn't really be blocking deploy on this anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering
Projects
None yet
Development

No branches or pull requests

6 participants