[HOLD for payment 2023-07-26] [$1000] Dev: Clicking on task header sometimes opens assignee page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a chat
2. Go to the "Assign task" section
3. Enter a title and create task
4. After creating click on task header somewhere

Expected Result:

Clicking on task header should not open assignee page

Actual Result:

Clicking on task header sometime open assignee page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.38-3
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3517.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688771023484909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0188e528004d0d6c31
• Upwork Job ID: 1678461651273142272
• Last Price Increase: 2023-07-10

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Clicking on task header sometimes opens assignee page

What is the root cause of that problem?

We're wrapping our subTitle inside a Pressable that filled the width of the header here:

App/src/pages/home/HeaderView.js

Lines 193 to 206 in 60f4817

	<PressableWithoutFeedback
	onPress={() => {
	Navigation.navigate(ROUTES.getReportRoute(props.report.parentReportID));
	}}
	accessibilityLabel={parentNavigationSubtitle}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.LINK}
	>
	<Text
	style={[styles.optionAlternateText, styles.textLabelSupporting, styles.link]}
	numberOfLines={1}
	>
	{parentNavigationSubtitle}
	</Text>
	</PressableWithoutFeedback>

Because of that, when user click on header, sometimes it will trigger the onPress function of the subTitle, which will open the
assignee page.

What changes do you think we should make in order to solve the problem?

Instead of making it fill the width of the header, we should only make the subTitle clickable in its actual width.

What alternative solutions did you explore? (Optional)

N/A

[thienlnam]

Only reproducible on dev so removing blocker

[thienlnam]

Actually, with the latest task redesign I don't think this bug exists anymore. If by assignee page you mean the DM - that is expected

[ayazhussain79]

@thienlnam this bug is on after new task redesign you can check that that is regression of this PR

[thienlnam]

@ayazhussain79 From the video in the issue post it looks like clicking the task header opens the chat with the assignee. That's expected behavior. Is there another issue you're trying to point out here that I'm missing?

[ayazhussain79]

@thienlnam please check that again you can assign task by clicking on header

screen-recording-2023-07-10-at-104019-pm_pOvdPfRc.mp4

[thienlnam]

Ohhh I see - yes that does look like a bug - thanks for clarifying

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0188e528004d0d6c31

[melvin-bot]

Triggered auto assignment to @tjferriss (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[Pujan92]

@thienlnam isn't it should open the assignee page for taskreport as looks correct as per the code?

App/src/pages/home/HeaderView.js

Line 165 in 0bdca70

onPress={() => (isTaskReport ? Navigation.navigate(ROUTES.getTaskReportAssigneeRoute(props.report.reportID)) : ReportUtils.navigateToDetailsPage(props.report))}

[thienlnam]

cc @jasperhuangg Was it intended to make this change? I believe the only spot we want to allow changing the assignee is when clicked below - thoughts?

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Clicking on header area opens assignee page.

What is the root cause of that problem?

Here, we are opening the assignee page if the report is a task report. This is a regression from this PR.

App/src/pages/home/HeaderView.js

Lines 164 to 167 in 751cf85

	<PressableWithoutFeedback
	onPress={() => (isTaskReport ? Navigation.navigate(ROUTES.getTaskReportAssigneeRoute(props.report.reportID)) : ReportUtils.navigateToDetailsPage(props.report))}
	style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]}
	disabled={isTaskReport && !ReportUtils.isOpenTaskReport(props.report)}

What changes do you think we should make in order to solve the problem?

If we want to open the details page when we click on the header area (except parent chat) then we can change line 165 to -

onPress={() => ReportUtils.navigateToDetailsPage(props.report)}

Also, we should remove the disabled prop in line 167 as we won't open assignee page in any case now.

What alternative solutions did you explore? (Optional)

NA

[Nikhil-Vats]

@thienlnam in the previous design, user was not able to open assignee page when clicking around header but user was able to open assignee page when clicked on the assignee shown after "To" (in old header design). But I agree, in the new design the header should not open assignee page.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Clicking on task header sometimes opens assignee page

What is the root cause of that problem?

I think this is intentional. Still it's very confusing for a user. we should only navigate to assignee page by clicking assignee. Navigating to details page like @Nikhil-Vats mentioned will not work. This the result of @Nikhil-Vats solution

Screen.Recording.2023-07-11.at.1.56.21.AM.mov

What changes do you think we should make in order to solve the problem?

There are 3 possible solutions to this

1. Pressing here should not do anything.
2. We can show profile details of Task Assigner
3. We can show dedicated details page as we show for IOU reports like this

What alternative solutions did you explore? (Optional)

[jasperhuangg]

cc @jasperhuangg Was it intended to make this change? I believe the only spot we want to allow changing the assignee is when clicked below - thoughts?

@thienlnam The header previously was used to open the assignee view. The design never specified that that wasn't supposed to happen so I just left things as is. I can update this though–I don't think it makes sense to have them both open the assignee modal.

[jasperhuangg]

Thanks for the proposals everyone, but I'm going to be tackling this internally since it's directly related to a PR I just merged!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[tjferriss]

Assigning @jasperhuangg and un-assigning @yuwenmemon as Jasper is working on the PR.

[jasperhuangg]

The PR is on prod cc @tjferriss

Let's get @ayazhussain79 paid out for reporting the bug and we should be good to close this out

[tjferriss]

@ayazhussain79 offer has been sent via Upworks

[ayazhussain79]

@tjferriss offer accepted, Thank you

[tjferriss]

Payment has been sent.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.42-26 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix a few things about tasks from the redesign #22586

If no regressions arise, payment will be issued on 2023-07-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty