[HOLD for payment 2023-07-20] [HOLD for payment 2023-07-17] Login - Crash when navigating to the concierge chat via deeplink after login

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Log out of NewDot
2. Go to https://staging.new.expensify.com/concierge
3. Verify that you are taken to the login screen
4. Log in to NewDot with any account

Expected Result:

You're navigated to the concierge chat after login

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.38.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6121132_Recording__5388.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cdf0596ececb29a0
• Upwork Job ID: 1683603845958860801
• Last Price Increase: 2023-07-24

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when navigating to Conceirge page via deeplink after login

What is the root cause of that problem?

In the navigateToConveirgeChat in Report.js, this is the condition

if (!Navigation.getReportIDFromRoute()) {
            Navigation.navigate(ROUTES.REPORT);
        }

This Navigation has no function called getReportIDFromRoute, so app crashes

What changes do you think we should make in order to solve the problem?

We change that check to

if (!Navigation.getTopmostReportID()) {
            Navigation.navigate(ROUTES.REPORT);
        }

[francoisl]

@c3024 are you available to submit a PR for this please?

[francoisl]

Since this is a deploy blocker, I'm going to submit a PR now.

[c3024]

@francoisl Sorry, I was sleeping and could not check the message. Would I be considered for payment for the proposal?

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[francoisl]

Yes @c3024 we'll compensate since we used your proposal (tagging a BugZero team member). Also assigning to @thesahindia for the PR review and testing.

[anmurali]

Not overdue, will pay tomorrow, which is the 20th!

[anmurali]

Payments can be processed now. I am OOO for 10 days so I am going to let someone else on the BZ team take care of this.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cdf0596ececb29a0

[melvin-bot]

Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.

[alexpensify]

I'm confirming the payment amounts and will prepare them tomorrow. Sorry for the delay!

Upwork link for payment: https://www.upwork.com/jobs/~01cdf0596ececb29a0

[alexpensify]

Alright, the payment process has started in Upwork. @c3024 please accept and I can complete the payment process.

Heads up, I didn't include the bonus because we just used the proposal, and an Expensify engineer implemented the code. Let me know if there are other questions.

---

@thesahindia - please update the checklist and within ND, please request payment + urgency bonus since you were involved in the review process.

[c3024]

Accepted the offer on Upwork @alexpensify

Heads up, I didn't include the bonus because we just used the proposal, and an Expensify engineer implemented the code

I understand, thanks.

[alexpensify]

Here is the payment summary:

• External issue reporter - N/A
• Contributor that fixed the issue - @c3024 $1000
• Contributor+ that helped on the issue and/or PR - @thesahindia $1500

Upwork Job:
https://www.upwork.com/jobs/~01cdf0596ececb29a0

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: #22502 (comment)

[alexpensify]

The payment has been sent to @c3024 via Upwork.

---

@thesahindia please complete the checklist, so we can close this GH. Heads up, please request payment from @JmillsExpensify. Anu is currently OOO. Thank you!

[thesahindia]

I will do it in the morning!

[alexpensify]

@thesahindia any update on the checklist here? I'd like to close this out soon. Thank you!

[thesahindia]

Ahh, I missed it somehow. We already have added a comment on the offending PR. We were using incorrect function. I don't think we need any change in the checklist and it doesn't need a regression test. So we don't have to do anything.

[alexpensify]

Thank you for that update! I'm going to close this out now.

[JmillsExpensify]

$1,500 payment for @thesahindia approved based on BZ summary.