[Hold #22062] Dev: Email Not Displayed in Tooltip on Workspace Members Page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to Settings > Workspace > New workspace
2. Navigate to the Member and Invite Members section
3. Hover over the user's profile image

Expected Result:

The email should be displayed in the tooltip when hovering over the user's profile picture

Actual Result:

The email is not showing in the tooltip on the workspace members page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.38-3 Dev
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-recording-2023-07-08-at-125721-am_oupX4yko.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688760556053339

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip doesn't show email/display name on Workspace Members page

What is the root cause of that problem?

account id is not passed here:

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 332 to 338 in 60f4817

	icons: [
	{
	source: UserUtils.getAvatar(item.avatar, item.accountID),
	name: item.login,
	type: CONST.ICON_TYPE_AVATAR,
	},
	],

and this causes missing accountID prop in UserDetailsTooltip:

App/src/components/UserDetailsTooltip/index.js

Line 19 in 60f4817

const userDetails = lodashGet(props.personalDetailsList, props.accountID, props.fallbackUserDetails);

What changes do you think we should make in order to solve the problem?

pass id: item.accountID in icons array above.

Updated code will look like this:

     { 
         id: item.accountID, 
         source: UserUtils.getAvatar(item.avatar, item.accountID), 
         name: item.login, 
         type: CONST.ICON_TYPE_AVATAR, 
     }, 

[chiragxarora]

dupe of #22062

[ayazhussain79]

@chiragxarora This bug isn't on staging yet so how is it dupe?
This bug is on many places:

[deetergp]

Am I missing something? This works fine for me locally running on updated main. Can someone who has experienced this already update their main, try again, and report back here?

[ayazhussain79]

@deetergp you can check that first go to the Settings > Workspaces > Members
You can also reproduce it while creating task on assignee page and also on reacted emoji tooltip #22485 (comment)

[deetergp]

Ahh, I was looking in the wrong place. Thanks @ayazhussain79 👍

[chiragxarora]

It's dupe because it's been reported earlier by me, the missing account ID on reaction list page and workspace members page.
I've reported both and proposals are being reviewed

[deetergp]

I've removed the blocker label because a) it's pretty trivial and b) it looks like the solutions being discussed in #22062 will likely fix this. If it doesn't, we can reopen the discussion here.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[deetergp]

Downgrading to weekly and putting a hold on it pending the outcome of #22062

[deetergp]

Still on hold

[deetergp]

It looks like #22062 did end up resolving this issue. Closing this one out.