[HOLD for payment 2023-08-08] [$1000] Web - The Not Allowed sign is not shown when dragging & dropping attachments if the settings or search bar is open

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to settings
2. Drag and drop a file.
3. Notice that the Not Allowed sign is not shown and when you drop it, the attachment is opened in a new tab.

Expected Result:

Not allowed sign is not shown

Actual Result:

Not allowed sign is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.36-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test57_Drag.Drop-1.mp4

Recording.3434.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688503808253309

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c9a4080884f501d
• Upwork Job ID: 1678901220787363840
2023-07-19
• Automatic offers:
• ishpaul777 | Contributor | 25726938
• daveSeife | Reporter | 25726939

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ishpaul777]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - The Not Allowed sign is not shown when dragging & dropping attachments if the settings or search bar is open

What is the root cause of that problem?

The current behaviour of dragover event datatransfer dropeffect is "copy" on setting screens.

What changes do you think we should make in order to solve the problem?

We need to add a eventlistner for dragover and set e.datatransfer.dropeffect = "none" in callback function when the right sidebar renders

Ref- https://codepen.io/SitePoint/pen/epQPNP

Here is What we need to do:

1. Create a NoDropZone component( this will just render the children passed as Prop. and apply dragover eventListner with
   e.datatransfer.dropeffect = "none"

only on web we apply the eventListner. on Native it will render the children only similar to what we have Done with DropZone component.

// /components/DragAndDrop/NoDropZone/index.js

import { useEffect } from 'react';
import PropTypes from 'prop-types';

const propTypes = {
	/** Content */
	children: PropTypes.node.isRequired,
};

function NoDropZone(props) {

	useEffect(() => {
		document.addEventListener('dragover', handleDragOver);

		return () => {
			document.removeEventListener('dragover', handleDragOver);
		};
	}, []);


	function handleDragOver(event) {
		event.preventDefault();
		event.dataTransfer.dropEffect = 'none';
	}


	return props.children;
}

NoDropZone.displayName = 'NoDropZone';
NoDropZone.propTypes = propTypes;

export default NoDropZone;

// /components/DragAndDrop/NoDropZone/index.native.js

const NoDropZone = (props) => props.children;

NoDropZone.displayName = 'NoDropZone';

export default NoDropZone;

2. Wrap the RHN with NoDropZone component.

Result-

https://www.loom.com/share/301ba3610bc845fda18b3c0fa977335b?sid=39f313e6-45e8-41a8-9ede-9fa251cd3a0e

What alternative solutions did you explore? (Optional)

we can add a eventlistner for both dragover and drop and event.preventDefault() on both listners it fails the drop gracefully(no new Tab opens) but the native cursor style for drop not-allowed (🚫 with white box) of windows, it still shows +Copy which indicates user can drop the file.

[melvin-bot]

@michaelhaxhiu Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010c9a4080884f501d

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[michaelhaxhiu]

This is indeed External, but I don't agree with the Expected Result as it stands -- it's not specific enough.

Expected Result:

Not allowed sign is not shown

What would be the best UX when dragging & dropping a file with the RHN/chatswitcher expanded?

[michaelhaxhiu]

Ok I'm gonna take a small step backward, and removing all assignments until we get clear on the Expected Result. I posted on the slack thread to converse further.

[melvin-bot]

📣 @TopTen1310! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[ishpaul777]

This is indeed External, but I don't agree with the Expected Result as it stands -- it's not specific enough.

Expected Result:

Not allowed sign is not shown

What would be the best UX when dragging & dropping a file with the RHN/chatswitcher expanded?

@michaelhaxhiu we can either just close the RHN when file is dragged over or show the drop not allowed cursor.

[melvin-bot]

@michaelhaxhiu Huh... This is 4 days overdue. Who can take care of this?

[michaelhaxhiu]

@ishpaul777 hmm collapsing the RHN could be a possible option. I feel like we should probably just match what we do on the desktop app ultimately (e.g. it just silently fails, and nothing changes unless you close the RHN).

So basically, looking below, we'd potentially remove the behavior from step 4 in bold so web matches desktop?

1. You are in a DM or group chat
2. RHN is expanded (search)
3. You click & drag an attachment into new expensify
4. A new tab opens up
5. The image fails to upload

On other websites, I have seen this exact same kind of behavior whereby a click & drag image upload will open a new tab. I'm not sure if it's fixable on web (as I'm not an engineer) but let's get C+ input too.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Ishpaul777/rhn no dropzone #23528

If no regressions arise, payment will be issued on 2023-08-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @robertKozik does not require payment (Contractor)
• @ishpaul777 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dangrous]

Thanks for clarifying @dangrous. Can you please clarify what's the impact of this regression on compensation?

So this will dock the pay due to the regression, unfortunately. (cc @michaelhaxhiu) Technically the 7 days also resets, though that's moot here since I think it was the same day

[ishpaul777]

Understood! Thanks for clarification.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[michaelhaxhiu]

Note: I'm preparing to go OOO for ~2 weeks and need a BZ buddy to watch over this in the meantime. 🙏

Next steps:

• There was a regression associated with the contributor PR, which is being handled via [HOLD for payment 2023-08-08] [$1000] Dev: Web - Can't click plus button after leaving a room #23881 as far as I can tell!
• Once [HOLD for payment 2023-08-08] [$1000] Dev: Web - Can't click plus button after leaving a room #23881 is finalized and paid, this job can be paid next.
• Assuming no other regressions arise, we should process payments as follows:
  [ ] Bug reporter @daveSeife $250
  [ ] Contributor @ishpaul777 $500 (50% docking on original price due to regression)
  (there is no C+ payment since RobertK is with SWM agency 👍 )

I'll take this over when I return if it's not complete. Thanks in advance @sakluger

[ishpaul777]

@michaelhaxhiu according to guidelines, isn't it just dock the speed bonus because of regression, i couldn't find the penalty for regression in docs

[michaelhaxhiu]

https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#payment-for-contributions

A 50% penalty will be applied to the Contributor and Contributor+ for each regression on an issue.

[ishpaul777]

found it! I beleive this is added recently so i missed it! Thanks @michaelhaxhiu

[sakluger]

I went ahead and paid @daveSeife for the bug report today. Tomorrow is the payment date for the rest assuming no more issues arise.

@robertKozik could you please complete the BugZero checklist (GH comment) when you have some time so that we can close this issue out after payment? Thanks!

[daveSeife]

@sakluger I have received the payment, thank you!

[robertKozik]

@sakluger I'm not sure whether I filled it right, as this issue was not fixing any regression (only caused one 🥲). Ping me if it should be filled another way

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: This PR was not fixing the regression
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@robertKozik] Determine if we should create a regression test for this bug. per @dangrous comment YES
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Go to settings
2. Drag and drop a file.
3. Verify that file cannot be dropped

Edited

[dangrous]

So you're right about it not being a regression, I believe. For the regression test, we might want to add one though - basically the testing steps in this issue. Thanks!

[ishpaul777]

Bump @sakluger for pay reminder. Thanks!

[sakluger]

Completed payment including 50% penalty for the regression.

@robertKozik thanks for filling out the checklist and writing out regression steps, looks perfect!