Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting user doesn't clear input text from search field on Split Bill page #22298

Closed
6 tasks done
kavimuru opened this issue Jul 5, 2023 · 12 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Click on 'FAB' icon
  2. Click on 'Split bill' link
  3. Enter amount & click on 'Next' button
  4. Search a user in the input field
  5. Select the user

Expected Result:

Text from the input field should be cleared

Actual Result:

Text from the input field is not cleared

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.37-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-05.22-02-39.mp4
Recording.1171.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688584083890729

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as off-topic.

@OSBotify
Copy link
Contributor

OSBotify commented Jul 5, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron marcaaron changed the title Selecting user doesn't clear input text from search field any longer Selecting user doesn't clear input text from search field on Split Bill page Jul 5, 2023
@marcaaron
Copy link
Contributor

I think this is possibly related to: #20271

cc @multijump @Julesssss @allroundexperts

@allroundexperts
Copy link
Contributor

@marcaaron Nops. This is a result of #20736

@allroundexperts
Copy link
Contributor

The removal of following in #20736 caused this.

if (!isOptionInList) {
  setSearchTerm('');
}

@marcaaron
Copy link
Contributor

@dukenv0307 Are you able to fix this quickly?

@Julesssss I'm not sure, but maybe you will want to just revert that PR to get the deploy unblocked.

@fedirjh
Copy link
Contributor

fedirjh commented Jul 5, 2023

@marcaaron I am not sure if this a blocker, This is the new behavior that we discussed in this thread

@greg-schroeder
Copy link
Contributor

Okay so it can't be expected behavior and also a deploy blocker. The thread linked above indicates this is actually expected

@greg-schroeder
Copy link
Contributor

I pinged in the thread to get some additional 👀

@Julesssss
Copy link
Contributor

Excellent, thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants