Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-07-14] [$250] Migrate MoneyRequestParticipantsSplitSelector.js to function component #16280

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 46 comments
Closed
1 task

[HOLD for payment 2023-07-14] [$250] Migrate MoneyRequestParticipantsSplitSelector.js to function component #16280

marcaaron opened this issue Mar 20, 2023 · 46 comments
Assignees
@Julesssss @allroundexperts @multijump @Christinadobrzyn
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Weekly KSv2
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a5adde5530f45b97
  • Upwork Job ID: 1665751679805845504
  • Last Price Increase: 2023-06-05
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@Julesssss Julesssss self-assigned this Mar 27, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate IOUParticipantsSplit.js to function component [HOLD][$250] Migrate IOUParticipantsSplit.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@marcaaron marcaaron added the Daily KSv2 label Jun 2, 2023
@marcaaron marcaaron changed the title [HOLD][$250] Migrate IOUParticipantsSplit.js to function component [$250] Migrate IOUParticipantsSplit.js to function component Jun 2, 2023
@marcaaron
Copy link
Contributor Author

Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@multijump
Copy link
Contributor

I can work on this issue

@Julesssss
Copy link
Contributor

I'm keeping this one, as I'd like to at least complete one migration myself.

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2023
@Julesssss
Copy link
Contributor

The page is now named: MoneyRequestParticipantsSplitSelector. I see state being used, so will investigate further.

@Julesssss Julesssss changed the title [$250] Migrate IOUParticipantsSplit.js to function component [$250] Migrate MoneyRequestParticipantsSplitSelector.js to function component Jun 5, 2023
@Julesssss
Copy link
Contributor

Phew. This one has it all:

  • Class component
  • State
  • componentDidUpdate

I'm struggling to break this down into smaller changes. I'm tempted to open this one up and pick up a simpler migration.

@Julesssss Julesssss added the External Added to denote the issue can be worked on by a contributor label Jun 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a5adde5530f45b97

@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

@Vishrut19
Copy link
Contributor

I want to work on it

@Julesssss
Copy link
Contributor

I tried but this was a tricky refactor for my first attempt, specifically the large getSections function was where I started to fail.

@multijump I'd be happy to assign this to you while I pick up a simpler one for my first migration.

@dummy-1111
Copy link
Contributor

I'd love to work on this.

@rushatgabhane rushatgabhane removed their assignment Jun 11, 2023
@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 11, 2023 •
edited
Loading

im out sick. @allroundexperts on c+ channel said that they're taking over. Thanks!

#20271 (comment)

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

📣 @allroundexperts You have been assigned to this job by @Julesssss!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@Christinadobrzyn
Copy link
Contributor

Monitoring PR - #20271

1 similar comment
@Christinadobrzyn
Copy link
Contributor

Monitoring PR - #20271

@melvin-bot
Copy link

melvin-bot bot commented Jul 4, 2023

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @multijump got assigned: 2023-06-05 16:11:32 Z
  • when the PR got merged: 2023-07-04 08:46:03 UTC
  • days elapsed: 20

On to the next one 🚀

@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@multijump
Copy link
Contributor

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Hello @allroundexperts @Christinadobrzyn
So everything is fine now?
Or there is something which I should change?

@allroundexperts
Copy link
Contributor

⚠️ Looks like this issue was linked to a Deploy Blocker here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Hello @allroundexperts @Christinadobrzyn So everything is fine now? Or there is something which I should change?

Nop. All good.

@Julesssss
Copy link
Contributor

Yeah, just to clarify we closed the linked issue as expected behavior.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 7, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate MoneyRequestParticipantsSplitSelector.js to function component [HOLD for payment 2023-07-14] [$250] Migrate MoneyRequestParticipantsSplitSelector.js to function component Jul 7, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot

This comment was marked as off-topic.

Sign in to view
@multijump
Copy link
Contributor

Hi @Julesssss @Christinadobrzyn
This issue was fully completed?

@Julesssss
Copy link
Contributor

Hi @Christinadobrzyn, this issue is ready to be paid when you're back from OOO.

@Julesssss Julesssss reopened this Jul 18, 2023
@Christinadobrzyn
Copy link
Contributor

okay hiring @allroundexperts as C+ and @multijump as contributor.

Upwork Internal posting - https://www.upwork.com/ab/applicants/1681244482343641088/job-details
Upwork External posting - https://www.upwork.com/jobs/~01ced557c4c463eb04

@multijump can you provide your Upwork profile link so I can invite you?

@allroundexperts
Copy link
Contributor

@Christinadobrzyn I'll be getting paid through the app.

@multijump
Copy link
Contributor

okay hiring @allroundexperts as C+ and @multijump as contributor.

Upwork Internal posting - https://www.upwork.com/ab/applicants/1681244482343641088/job-details Upwork External posting - https://www.upwork.com/jobs/~01ced557c4c463eb04

@multijump can you provide your Upwork profile link so I can invite you?

Hi, @Christinadobrzyn
https://www.upwork.com/freelancers/~0168534bdf28bd4cf8
Here is my upwork profile.
Thanks.

@anmurali
Copy link

@allroundexperts is paid

@Christinadobrzyn
Copy link
Contributor

Thanks @multijump - sent an offer to you, if you can accept it, I'll pay this out!

@multijump
Copy link
Contributor

Hi, @Christinadobrzyn
I accepted your offer.
Thanks.

@Christinadobrzyn
Copy link
Contributor

Thanks @multijump! I've paid you $250 through Upwork. Going to close this GH and the Upwork job posting but please reopen if I've missed something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

@allroundexperts allroundexperts

@multijump multijump

@Christinadobrzyn Christinadobrzyn

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests