[HOLD for payment 2023-08-08] [$1000] [HOLD] Context menu from LHN is visible even if report page is opened on resize

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Right click an option in LHN.
2. Resize the window to small while the menu is still open

Expected Result:

The menu should either stay open and LHN should be visible or the menu should close and report screen should be visible.

Actual Result:

The menu as well as report screen is visible while the action LHN option is hidden.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.2276.mp4

Screen.Recording.2023-06-26.at.10.27.18.PM.1.mov

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687798787632109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cdbc23c40a03345b
• Upwork Job ID: 1681398364212076544
2023-07-18
• Automatic offers:
• | | 0
• | | 0
• esh-g | Reporter | 25767058

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[spcheema]

Proposed solution

Please re-state the problem that we are trying to solve in this issue.

Context menu from LHN is visible even if report page is opened on resize. S

What is the root cause of that problem?

We are not hiding the ReportActionMenu whenever screen size changes to small and a report is selected.

What changes do you think we should make in order to solve the problem?

We can utilise the isSmallScreenWidth props on SidebarLinks render to check screen size and hide the ReportActionMenu is it's set in the contextMenuRef

        if (this.props.isSmallScreenWidth)
        {
           // ReportActionContextMenu
            hideContextMenu(false)
        }

What alternative solutions did you explore? (Optional)

N/A

[esh-g]

I think we should put this on hold for this issue: #20370 (comment)

[maddylewis]

holding for - #20370 (comment)

[maddylewis]

still holding

[maddylewis]

okay this is closed now - #20370 (comment)

I'll add the External label so a C+ can confirm if we still need to fix this one.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cdbc23c40a03345b

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[maddylewis]

@sobitneupane - this issue was on hold for #20370

is this something that still needs to be addressed? or, did the fix for #20370 resolve this bug? lmk - thanks!

[spcheema]

@maddylewis This bug still exists on prod https://new.expensify.com/

Watch 👇🏼
https://www.loom.com/share/a31d89b367b7422783804dcd85fc856f?sid=3bd571e7-25de-4474-8ab4-3a8e659e481b

[melvin-bot]

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @spcheema You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[spcheema]

@sobitneupane PR is ready for review #23728

[melvin-bot]

🎯 ⚡️ Woah @sobitneupane / @spcheema, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @spcheema got assigned: 2023-07-26 15:39:34 Z
• when the PR got merged: 2023-07-28 18:28:38 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/21929 - Hide context menu from LHN window resize #23728

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @spcheema requires payment
• @sobitneupane does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#16079

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#16079 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#21929 (comment)

[sobitneupane]

Regression Test Proposal

1. Right click an option in LHN to open context menu.
2. Resize the window to small such that LHN is hidden.
3. Verify right click context menu disappeared on window resize.
4. Now go back to LHN menu, again right click on any item to open context menu
5. Resize window from small to wide
6. Verify context menu disappeared.

Do we agree 👍 or 👎

[maddylewis]

Payments:

• @esh-g ($250 reporting bonus paid via Upwork)
• @spcheema (Contributor - $1500 paid via Upwork)
• @sobitneupane (C+ - $1500 paid via NewDot)

---

• Contributor hired - July 26
• PR merged - July 28
• Eligible for urgency bonus

[maddylewis]

@sobitneupane is receiving payment via NewDot so i believe we are all set to close this one out.

[spcheema]

Thanks @sobitneupane @stitesExpensify & @maddylewis

[sobitneupane]

Requested payment on newDot.

#21929 (comment)

[JmillsExpensify]

Reviewed the details for @sobitneupane. $1,500 approved for payment via NewDot based on BZ summary.